Start with fresh values for nested sagas #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2022 10:35
Currently, nested sagas see the results accumulated so far by outer saga which is not an intended behavior. Also, nested more than one saga is somewhat broken currently. This PR fixes both issues allowing nesting as many sagas as one may want and not leaking data from outer saga(s) to the current one.
madebyherzblut
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, nested sagas see the results accumulated so far by the outer saga
which is not intended behaviour.
Also, nested more than one saga is somewhat broken currently.
This PR fixes both issues allowing nesting as many sagas as one may want
and not leaking data from outer saga(s) to the current one.
Closes #23