Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify/clean up UI #134

Open
3 of 6 tasks
AndreiMiculita opened this issue Feb 22, 2024 · 2 comments
Open
3 of 6 tasks

Clarify/clean up UI #134

AndreiMiculita opened this issue Feb 22, 2024 · 2 comments

Comments

@AndreiMiculita
Copy link

AndreiMiculita commented Feb 22, 2024

Hello, I believe the file transfer UI can be improved in some regards:

  • Fix username showing up as "null" if it's not loaded yet. To most users "null" doesn't mean anything special like it does in programming. They'll think it's another username. You can show a skeleton element instead if the username/hostname are not known yet.
Screenshot

Screenshot_20240222-144807_Warpinator

Screenshot

Screenshot_20240222-143443_Warpinator

  • Add a text label for the "Send" button. It's unclear atm and the UI is bare anyway, so there is no risk of overcluttering.
Screenshot

Screenshot_20240222-143443_Warpinator

  • Add text labels for the options "File" and "Folder". Currently, this looks very vague and takes a bit of guesswork to see that a taller rectangle is a file and a wider one is a folder. Grey out the "Upload" button or do something to show it is not available when the two options are expanded.
Screenshot

Screenshot_20240222-143439_Warpinator

  • Allow swiping downloads to the side to dismiss. Maybe also add a label to the button that dismisses them (bottom-left).

  • Fix toast only pushing up the "Dismiss all" button but not the "Send" button

Screenshot

Screenshot_20240222-145156_Warpinator

Thanks!

@slowscript
Copy link
Owner

Thanks for the well-written feedback. Having it in points makes it easy to go through. I fixed some of the points in 1.7.1. Swiping away transfers will be done when I have some more time.

I am however not sure about adding labels to everything. Floating action button with a label looks like this and to me it does not seem suitable for this use case. They are simply too large and given that the screen has many of them it would not look good.

I didn't gray out the upload button when it is expanded because tapping it again makes it collapse back. It now changes icon to make this more clear.

@AndreiMiculita
Copy link
Author

Wrt labels, I understand trying to keep it minimal but this also makes it harder to give indications to most users. Compare the readability of these two tutorials and which you'd rather be reading over a phone call:

  • Press "Send", then press "Send file"
  • Press the button on the bottom right with an arrow pointing up, then press the button with the taller rectangle

Also for the two popup FABs, they can be made smaller to indicate visual hierarchy. The MD3 design guidelines seem to advise that.

Or how about doing what Google Calendar does and show the labels after you click on the button?

Like this image, but instead of "Event" you have "Send file" and only one secondary button that says "Send folder"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants