Revert "Always name parameters in code gen" (#1980)

Reverts #1977

Author: ZacSweers

circuit-codegen/src/main/kotlin/com/slack/circuit/codegen/CircuitSymbolProcessorProvider.kt

@@ -303,7 +303,13 @@ private class CircuitSymbolProcessor(
             FactoryType.UI
           }
         val assistedParams =
-          fd.assistedParameters(symbols, logger, screenKSType, factoryType == FactoryType.PRESENTER)
+          fd.assistedParameters(
+            symbols,
+            logger,
+            screenKSType,
+            factoryType == FactoryType.PRESENTER,
+            includeParameterNames = codegenMode != KOTLIN_INJECT_ANVIL,
+          )
         codeBlock =
           when (factoryType) {
             FactoryType.PRESENTER ->
@@ -470,6 +476,7 @@ private class CircuitSymbolProcessor(
               logger,
               screenKSType,
               allowNavigator = factoryType == FactoryType.PRESENTER,
+              includeParameterNames = codegenMode != KOTLIN_INJECT_ANVIL,
             )
           }
         codeBlock =
@@ -541,6 +548,7 @@ private fun KSFunctionDeclaration.assistedParameters(
   logger: KSPLogger,
   screenType: KSType,
   allowNavigator: Boolean,
+  includeParameterNames: Boolean,
 ): CodeBlock {
   return buildSet {
       for (param in parameters) {
@@ -575,7 +583,15 @@ private fun KSFunctionDeclaration.assistedParameters(
       }
     }
     .toList()
-    .map { CodeBlock.of("${it.name} = ${it.factoryName}") }
+    .map {
+      val prefix =
+        if (includeParameterNames) {
+          "${it.name} = "
+        } else {
+          ""
+        }
+      CodeBlock.of("$prefix${it.factoryName}")
+    }
     .joinToCode(",·")
 }
 

circuit-codegen/src/test/kotlin/com/slack/circuit/codegen/CircuitSymbolProcessorTest.kt

@@ -1328,54 +1328,6 @@ class CircuitSymbolProcessorTest {
     }
   }
 
-  // Regression test for https://github.com/slackhq/circuit/issues/1704
-  @Test
-  fun parameterOrderDoesNotMatter() {
-    assertGeneratedFile(
-      sourceFile =
-        kotlin(
-          "ParameterOrdering.kt",
-          """
-          package test
-
-          import com.slack.circuit.codegen.annotations.CircuitInject
-          import com.slack.circuit.runtime.screen.StaticScreen
-          import androidx.compose.runtime.Composable
-          import androidx.compose.ui.Modifier
-
-          data object Static : StaticScreen
-
-          @CircuitInject(Static::class, AppScope::class)
-          @Composable
-          fun StaticUi(screen: Static, modifier: Modifier) {}
-        """
-            .trimIndent(),
-        ),
-      generatedFilePath = "test/StaticUiFactory.kt",
-      expectedContent =
-        """
-        package test
-
-        import com.slack.circuit.runtime.CircuitContext
-        import com.slack.circuit.runtime.CircuitUiState
-        import com.slack.circuit.runtime.screen.Screen
-        import com.slack.circuit.runtime.ui.Ui
-        import com.slack.circuit.runtime.ui.ui
-        import com.squareup.anvil.annotations.ContributesMultibinding
-        import javax.inject.Inject
-
-        @ContributesMultibinding(AppScope::class)
-        public class StaticUiFactory @Inject constructor() : Ui.Factory {
-          override fun create(screen: Screen, context: CircuitContext): Ui<*>? = when (screen) {
-            Static -> ui<CircuitUiState> { _, modifier -> StaticUi(modifier = modifier, screen = screen) }
-            else -> null
-          }
-        }
-      """
-          .trimIndent(),
-    )
-  }
-
   private enum class CodegenMode {
     ANVIL,
     HILT,