Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cache layer #62

Closed
abjerner opened this issue Nov 27, 2019 · 2 comments
Closed

Introduce cache layer #62

abjerner opened this issue Nov 27, 2019 · 2 comments
Labels
priority/should-have status/idea The ideas in this issue are great idea, but we're not ready to work on it in the near future umbraco/v8 Issues and tasks related to Umbraco 8.

Comments

@abjerner
Copy link
Member

The HTTP module will make a handful of SQL queries per request (think it's four at worst). With a site that receives many 404 request, this may affect performance of the database and site.

For a number of reasons, it may be ideal to have a cache layer in front of the database. A cache layer will reduce the amount of calls to the database considerably, and also allow us to do new things - eg. adding support for forced redirects.

@abjerner abjerner added status/idea The ideas in this issue are great idea, but we're not ready to work on it in the near future priority/should-have umbraco/v8 Issues and tasks related to Umbraco 8. labels Nov 27, 2019
@ronaldbarendse
Copy link

As commented in #59 (comment), caching won't make it faster, especially if you have a lot of redirects (as all redirects must be retrieved from the database first).

If Regex redirects get supported, those might indeed need to be cached, as you can't query them directly in the database (based on the current URL) 😉

@abjerner
Copy link
Member Author

@ronaldbarendse thanks for the feedback. I can't remember my exact thoughts when I created this issue, so maybe the priority label can be discussed. But I think it's still something that at least is worth investigating.

However as things are now, it's not something I currently have the time to look into 😮

@abjerner abjerner closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/should-have status/idea The ideas in this issue are great idea, but we're not ready to work on it in the near future umbraco/v8 Issues and tasks related to Umbraco 8.
Projects
None yet
Development

No branches or pull requests

2 participants