Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirecting a Request with a tracking Querystring, without 'ticking' forward Querystring #209

Open
marcemarc opened this issue Aug 5, 2024 · 0 comments
Labels
type/bug Something isn't working

Comments

@marcemarc
Copy link

Which version of Skybrud Redirects are you using? (Please write the exact version, example: 4.0.8)

13.0.4

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.3.2

Bug description

So I'm not really sure if this is by 'design', and if I've understood correctly, or am reading the code wrong.

But we have a client site that uses Skybrud Redirects (I mean what projects don't these days, loving your work!)

and they had setup lots of redirects for pages that had moved (that's what redirect plugin is for)

for example:

/us/tanzania/solo/ -> /us/tanzania/tanzania-you/solo/

All worked splendidly well!

They use the Lookalike Audience feature of Facebook, to send traffic to their site and this appends a huge tracking querystring to the URL

_its=JTdCJTIydmlkJTIyJTNBJTIyMWM5ZWVkMDktYjc5Msddff00ZmExLWFjMjctNmU2ZDRmMDRiZssTIyJTJDJTIyc3RhdGUlMjIlM0ElMjJybHR%2BMTcwNzA5MTIwMX5sYW5kfjJfODIxOTBfZGlyZWN0XzUyZDdhNjhhM2FkYWIxYzJiMmQ4MmFjMzcyMWUxMjA3JTIyJTJDJTIyc2l0ZUlkJTIyJTNBMTE0NTAlN0Q%3D

and they had so many of these to update, that they relied on the redirect, which seemed to work fine...

... but then the site was upgraded to Umbraco 13, and Skybrud.Redirects upgraded to 13.0.4

and suddenly all the redirects stopped working, and we discovered the reason here:

6b02b65

image

And now the redirect ONLY works if the 'forward query string' option is ticked.

Which typing this out - kinda makes sense for tracking querystring params, and I guess most other scenarios.

So is this by design?

or should it still be possible to have the previous functionality, even though I can't really think of a reason why?

eg without the forward query string box ticked, it still performs the redirect, but strips the querystring?

sorry for the rambling 'rubber ducking', I'm coming around to the... this is by design!

@marcemarc marcemarc added the type/bug Something isn't working label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant