Add coverity modeling file

[jiridanek]

Public documentation

• https://scan.coverity.com/tune
• https://sig-product-docs.synopsys.com/bundle/coverity-docs-2022.12/page/customizing_coverity/topics/models_primitives/primitives/r_models_primitives_c_cpp_concurrency.html

Private documentation (redirects to Red Hat VPN)

• https://url.corp.redhat.com/cov-customizing, and change ".brq." in the url to ".brq2."

Example code from a random project

• https://qemu.googlesource.com/skiboot/+/64e239b22ddae886c2c7914a747b1d521603c699/coverity-model.c

[jiridanek]

The docs for coverity models mention some tool cov-make-library which converts "modeling files" into XML configs. Looking at this random project qemu/skiboot@79e829c they don't seem to use this tool at all.

Also, I am confused when one can use the coverity annotations in the code directly and when separate "modeling file" is required or desired.

c.f. https://github.com/search?q=__coverity_exclusive_lock_acquire__&type=code

[jiridanek]

Coverity Scan has an upload field for a modeling file in the WebUI, so I guess there are the possibilities to either submit it through the cli tools when doing analysis, or have a file uploaded on the server through web ui https://scan.coverity.com/projects/skupper-router?tab=analysis_settings

[jiridanek]

Actually, it seems to be possible to put this into the sources directly, I already found #212 (comment) some time ago (usage in OpenOffice)

[jiridanek]

The modeling file (or any such annotations) are supposed to be added only if coverity produces false positives without it. It is not something to add without first looking at the scan results

https://sig-product-docs.synopsys.com/bundle/coverity-docs-2022.12/page/customizing_coverity/topics/models_primitives/c_models_use_cases.html

[jiridanek]

Nothing to be done for the moment. This really is something to do while reviewing Coverity results after realizing that there's something the tool needs help with.