Skip to content

Commit 3ebe152

Browse files
committed
Fixes #1830 - Check for the reception of aborted deliveries only in single-router scenarios.
1 parent 60cd6ec commit 3ebe152

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

tests/system_tests_delivery_abort.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ def __init__(self, sender_host, receiver_host, address):
136136
self.sender_host = sender_host
137137
self.receiver_host = receiver_host
138138
self.address = address
139+
# If the sender and receiver are on the same router, we expect to see aborted deliveries.
140+
# If there are multiple routers, aborted deliveries may be absorbed by downrange routers and not seen here.
141+
self.same_router = sender_host == receiver_host
139142

140143
self.sender_conn = None
141144
self.receiver_conn = None
@@ -152,9 +155,14 @@ def __init__(self, sender_host, receiver_host, address):
152155
self.sent_stream = 0
153156
self.program = ['Send_Short_1', 'Send_Long_Truncated', 'Send_Short_2', 'Send_Short_3']
154157
self.result = []
155-
self.expected_result = ['Send_Short_1', 'Aborted_Delivery', '2', '2', '2', '2', '2',
156-
'2', '2', '2', '2', '2', 'Send_Short_2', '3', '3', '3', '3',
157-
'3', '3', '3', '3', '3', '3', 'Send_Short_3']
158+
if self.same_router:
159+
self.expected_result = ['Send_Short_1', 'Aborted_Delivery', '2', '2', '2', '2', '2',
160+
'2', '2', '2', '2', '2', 'Send_Short_2', '3', '3', '3', '3',
161+
'3', '3', '3', '3', '3', '3', 'Send_Short_3']
162+
else:
163+
self.expected_result = ['Send_Short_1', '2', '2', '2', '2', '2',
164+
'2', '2', '2', '2', '2', 'Send_Short_2', '3', '3', '3', '3',
165+
'3', '3', '3', '3', '3', '3', 'Send_Short_3']
158166

159167
def timeout(self):
160168
self.error = "Timeout Expired - Unprocessed Ops: %r, Result: %r" % (self.program, self.result)
@@ -224,7 +232,8 @@ def on_message(self, event):
224232
self.timer.cancel()
225233

226234
def on_aborted(self, event):
227-
self.result.append('Aborted_Delivery')
235+
if self.same_router:
236+
self.result.append('Aborted_Delivery')
228237
self.send()
229238

230239
def run(self):

0 commit comments

Comments
 (0)