Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update Twitter icon and add Bluesky icon #1212

Merged

Conversation

sylvaincom
Copy link
Contributor

Fix #1211

@sylvaincom sylvaincom marked this pull request as ready for review January 10, 2025 15:02
@GaelVaroquaux
Copy link
Member

How is this PR linked to the other PR #1192 ?

@sylvaincom
Copy link
Contributor Author

sylvaincom commented Jan 10, 2025

Oh sorry missed that one, I guess this PR adds Bluesky as well, but keeps and renames X (ex-Twitter) ; feel free to close this one

Copy link
Member

@jeromedockes jeromedockes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @sylvaincom !

@jeromedockes jeromedockes merged commit e54c84e into skrub-data:main Jan 27, 2025
25 checks passed
Vincent-Maladiere pushed a commit to Vincent-Maladiere/skrub that referenced this pull request Jan 27, 2025
@sylvaincom sylvaincom deleted the fix-issue-1211-icon-twitter-bluesky branch January 27, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Update Twitter icon and add Bluesky icon
3 participants