Skip to content

Conversation

@mattac21
Copy link
Collaborator

@mattac21 mattac21 commented Sep 26, 2025

Note

Simplifies Ethereum metrics to TPS-only via block-level tx counts and trims, and adjusts gas limit buffers (+30% baseline in factory, ~2% estimate buffer in wallet).

  • Metrics (chains/ethereum/metrics/collector.go):
    • Refactors collection to TPS-only using lightweight BlockStat (block number, total txs, timestamp).
    • Concurrently fetches blocks, aggregates per-block tx counts, trims empty edge blocks, computes runtime and TPS, and logs concise run info.
    • Removes receipt-based analysis, per-message stats, gas/utilization analytics, and detailed LoadTestResult population (returns empty struct).
  • TX Building:
    • txfactory: when using baselines, set GasLimit to baseline + 30% instead of exact baseline.
    • wallet: reduces gas estimate buffer from 1/20 (~5%) to 1/50 (~2%).

Written by Cursor Bugbot for commit a9269a8. This will update automatically on new commits. Configure here.

cursor[bot]

This comment was marked as outdated.


// add a 20% buffer to limit (common practice)
buffer := gasLimit / 20
buffer := gasLimit / 50
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gas Buffer Mismatch Causes Transaction Failures

The gas buffer calculation changed from 5% to 2% (gasLimit / 20 to gasLimit / 50). This reduction contradicts the existing comment claiming a "20% buffer" and significantly lowers the safety margin, potentially causing transactions to fail due to insufficient gas.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants