Skip to content

Commit a7daf6d

Browse files
committed
Fix mysql build
1 parent e0d244e commit a7daf6d

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

Makefile

+12-5
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ CGID ?= $(LOCAL_GID)
2424
# Define network name.
2525
COMPOSE_NET_NAME := $(COMPOSE_PROJECT_NAME)_front
2626

27+
# Determine mysql data directory if defined
28+
ifeq ($(shell docker-compose config --services | grep mysql),mysql)
29+
MYSQL_DIR=$(shell cd docker && realpath $(DB_DATA_DIR))/$(COMPOSE_PROJECT_NAME)_mysql
30+
endif
31+
2732
# Execute php container as regular user
2833
php = docker-compose exec -T --user $(CUID):$(CGID) php ${1}
2934
# Execute php container as root user
@@ -51,8 +56,8 @@ ifeq ($(strip $(COMPOSE_PROJECT_NAME)),projectname)
5156
$(info Please review your project settings and run `make all` again.)
5257
exit 1
5358
endif
54-
ifeq ($(shell docker-compose config --services | grep mysql),mysql)
55-
mkdir -p $(DB_DATA_DIR)/$(COMPOSE_PROJECT_NAME)_mysql
59+
ifdef MYSQL_DIR
60+
mkdir -p $(MYSQL_DIR) && chmod 777 $(MYSQL_DIR)
5661
endif
5762
make -s down
5863
@echo "Updating containers..."
@@ -139,7 +144,10 @@ ifneq ($(shell docker-compose ps -q php),'')
139144
endif
140145
make -s down
141146
@for i in $(DIRS); do if [ -d "$$i" ]; then echo "Removing $$i..."; docker run --rm -v $(shell pwd):/mnt $(IMAGE_PHP) sh -c "rm -rf /mnt/$$i"; fi; done
142-
if [ -d $(DB_DATA_DIR) ]; then echo "Removing mysql data $(DB_DATA_DIR) ..."; docker run --rm --user 0:0 -v $(shell pwd):/mnt/2rm $(IMAGE_PHP) sh -c "rm -rf /mnt/2rm/$(DB_DATA_DIR)"; fi
147+
ifdef MYSQL_DIR
148+
@echo "Removing mysql data from $(MYSQL_DIR) ..."
149+
docker run --rm --user 0:0 -v $(shell dirname $(MYSQL_DIR)):/mnt $(IMAGE_PHP) sh -c "rm -fr /mnt/`basename $(MYSQL_DIR)`"
150+
endif
143151
ifeq ($(CLEAR_FRONT_PACKAGES), yes)
144152
make clear-front
145153
endif
@@ -165,5 +173,4 @@ dev:
165173
## Run drush command in PHP container. To pass arguments use double dash: "make drush dl devel -- -y"
166174
drush:
167175
$(call php, $(filter-out "$@",$(MAKECMDGOALS)))
168-
$(info "To pass arguments use double dash: "make drush dl devel -- -y"")
169-
176+
$(info "To pass arguments use double dash: "make drush en devel -- -y"")

docker/docker-compose.override.yml.default

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ services:
2424
# - front
2525

2626
# mysql:
27-
# image: percona:5.7.22
27+
# image: percona:5.7
2828
# container_name: "${COMPOSE_PROJECT_NAME}_mysql"
2929
# volumes:
3030
# - ${DB_DATA_DIR}/${COMPOSE_PROJECT_NAME}_mysql:/var/lib/mysql:Z

0 commit comments

Comments
 (0)