fix(cli): accept Artifact downloads from a service subdomain - #134
Merged
Conversation
The service now serves Artifact bytes from artifacts.skilld.dev, but the origin allowlist only knew the API origin. Every skilld: run and install therefore failed at the final hop with REMOTE_ORIGIN_REJECTED, after the resolution, trusted root, and grant had all succeeded. A grant may now point at the service origin or at an https subdomain of it. Every other origin is still rejected before the request leaves. Claude-Session: https://claude.ai/code/session_01ASGK6drkuCbo7vsPQcYCvn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Every
skilld:run and install on 3.0.0-beta.4 dies at the last hop:The resolution, trusted root, and grant all succeed. The grant then points at
https://artifacts.skilld.dev/..., which skilld.dev has served since skilld-dev/skilld.dev#54, and the CLI only allows the API origin itself. The tests never caught it because the fake grant sits on the same127.0.0.1:8787origin as the API.A grant may now point at the service origin or at an https subdomain of it. Anything else is still refused before the request leaves.
I went with the subdomain rule rather than a hard coded
artifacts.skilld.devso a staging endpoint keeps working. Open to pinning the host in the trusted root instead if you would rather the service name it.https://claude.ai/code/session_01ASGK6drkuCbo7vsPQcYCvn