fix(sync): skip LLM prompt when all sections are cached (#40)

Author: harlan-zw

src/commands/sync-parallel.ts

@@ -14,6 +14,9 @@ import {
   getModelLabel,
   linkSkillToAgents,
   optimizeDocs,
+  SECTION_MERGE_ORDER,
+  SECTION_OUTPUT_FILES,
+  wrapSection,
 
 } from '../agent/index.ts'
 import {
@@ -25,6 +28,7 @@ import {
   isCached,
   linkPkgNamed,
   listReferenceFiles,
+  readCachedSection,
   resolvePkgDir,
 } from '../cache/index.ts'
 import { defaultFeatures, readConfig, registerProject } from '../core/config.ts'
@@ -52,7 +56,7 @@ import {
   resolveBaseDir,
   resolveLocalDep,
 } from './sync-shared.ts'
-import { ensureAgentInstructions, ensureGitignore, selectLlmConfig, writePromptFiles } from './sync.ts'
+import { DEFAULT_SECTIONS, ensureAgentInstructions, ensureGitignore, selectLlmConfig, writePromptFiles } from './sync.ts'
 
 type PackageStatus = 'pending' | 'resolving' | 'downloading' | 'embedding' | 'exploring' | 'thinking' | 'generating' | 'done' | 'error'
 
@@ -221,13 +225,68 @@ export async function syncPackagesParallel(config: ParallelSyncConfig): Promise<
     }
   }
 
-  // Phase 2: Ask about LLM enhancement (skip if -y without model, or skipLlm config)
+  // Apply cached LLM sections for packages that have all sections cached
+  const cachedPkgs: string[] = []
+  if (!config.force) {
+    for (const pkg of successfulPkgs) {
+      const data = skillData.get(pkg)!
+      const resolvedName = data.resolved.name
+      const allCached = DEFAULT_SECTIONS.every((s) => {
+        const outputFile = SECTION_OUTPUT_FILES[s]
+        return readCachedSection(resolvedName, data.version, outputFile) !== null
+      })
+      if (allCached) {
+        const baseDir = resolveBaseDir(cwd, config.agent, config.global)
+        const skillDir = join(baseDir, data.skillDirName)
+        const cachedParts: string[] = []
+        for (const s of SECTION_MERGE_ORDER) {
+          if (!DEFAULT_SECTIONS.includes(s))
+            continue
+          const outputFile = SECTION_OUTPUT_FILES[s]
+          const content = readCachedSection(resolvedName, data.version, outputFile)
+          if (content)
+            cachedParts.push(wrapSection(s, content))
+        }
+        const cachedBody = cachedParts.join('\n\n')
+
+        const skillMd = generateSkillMd({
+          name: resolvedName,
+          version: data.version,
+          releasedAt: data.resolved.releasedAt,
+          dependencies: data.resolved.dependencies,
+          distTags: data.resolved.distTags,
+          body: cachedBody,
+          relatedSkills: data.relatedSkills,
+          hasIssues: data.hasIssues,
+          hasDiscussions: data.hasDiscussions,
+          hasReleases: data.hasReleases,
+          hasChangelog: data.hasChangelog,
+          docsType: data.docsType,
+          hasShippedDocs: data.shippedDocs,
+          pkgFiles: data.pkgFiles,
+          generatedBy: 'cached',
+          dirName: data.skillDirName,
+          packages: data.packages,
+          repoUrl: data.resolved.repoUrl,
+          features: data.features,
+        })
+        writeFileSync(join(skillDir, 'SKILL.md'), skillMd)
+        cachedPkgs.push(pkg)
+      }
+    }
+  }
+
+  const uncachedPkgs = successfulPkgs.filter(pkg => !cachedPkgs.includes(pkg))
+  if (cachedPkgs.length > 0)
+    p.log.success(`Applied cached SKILL.md sections for ${cachedPkgs.join(', ')}`)
+
+  // Phase 2: Ask about LLM enhancement (skip if -y without model, skipLlm config, or all cached)
   const globalConfig = readConfig()
-  if (successfulPkgs.length > 0 && !globalConfig.skipLlm && !(config.yes && !config.model)) {
+  if (uncachedPkgs.length > 0 && !globalConfig.skipLlm && !(config.yes && !config.model)) {
     const llmConfig = await selectLlmConfig(config.model)
 
     if (llmConfig?.promptOnly) {
-      for (const pkg of successfulPkgs) {
+      for (const pkg of uncachedPkgs) {
         const data = skillData.get(pkg)!
         const baseDir = resolveBaseDir(cwd, config.agent, config.global)
         const skillDir = join(baseDir, data.skillDirName)
@@ -251,21 +310,21 @@ export async function syncPackagesParallel(config: ParallelSyncConfig): Promise<
     else if (llmConfig) {
       p.log.step(getModelLabel(llmConfig.model))
       // Reset states for LLM phase
-      for (const pkg of successfulPkgs) {
+      for (const pkg of uncachedPkgs) {
         states.set(pkg, { name: pkg, status: 'pending', message: 'Waiting...' })
       }
       render()
 
       const llmResults = await Promise.allSettled(
-        successfulPkgs.map(pkg =>
+        uncachedPkgs.map(pkg =>
           limit(() => enhanceWithLLM(pkg, skillData.get(pkg)!, { ...config, model: llmConfig.model }, cwd, update, llmConfig.sections, llmConfig.customPrompt)),
         ),
       )
 
       logUpdate.done()
 
       const llmSucceeded = llmResults.filter(r => r.status === 'fulfilled').length
-      p.log.success(`Enhanced ${llmSucceeded}/${successfulPkgs.length} skills with LLM`)
+      p.log.success(`Enhanced ${llmSucceeded}/${uncachedPkgs.length} skills with LLM`)
     }
   }
 

src/commands/sync.ts

@@ -16,7 +16,9 @@ import {
   linkSkillToAgents,
   portabilizePrompt,
   sanitizeName,
+  SECTION_MERGE_ORDER,
   SECTION_OUTPUT_FILES,
+  wrapSection,
 } from '../agent/index.ts'
 import {
   ensureCacheDir,
@@ -27,6 +29,7 @@ import {
   isCached,
   linkPkgNamed,
   listReferenceFiles,
+  readCachedSection,
   resolvePkgDir,
 } from '../cache/index.ts'
 import { getInstalledGenerators, introLine, isInteractive, promptForAgent, resolveAgent, sharedArgs } from '../cli-helpers.ts'
@@ -519,9 +522,55 @@ async function syncSinglePackage(packageSpec: string, config: SyncConfig): Promi
 
   p.log.success(config.mode === 'update' ? `Updated skill: ${relative(cwd, skillDir)}` : `Created base skill: ${relative(cwd, skillDir)}`)
 
-  // Ask about LLM optimization (skip if -y flag, skipLlm config, or model already specified)
+  // Check if all default sections are already cached (skip prompt entirely if so)
+  const allSectionsCached = !config.force && DEFAULT_SECTIONS.every((s) => {
+    const outputFile = SECTION_OUTPUT_FILES[s]
+    return readCachedSection(packageName, version, outputFile) !== null
+  })
+
+  if (allSectionsCached) {
+    // Silently apply cached LLM content without prompting
+    const cachedParts: string[] = []
+    for (const s of SECTION_MERGE_ORDER) {
+      if (!DEFAULT_SECTIONS.includes(s))
+        continue
+      const outputFile = SECTION_OUTPUT_FILES[s]
+      const content = readCachedSection(packageName, version, outputFile)
+      if (content)
+        cachedParts.push(wrapSection(s, content))
+    }
+    const cachedBody = cachedParts.join('\n\n')
+
+    const skillMd = generateSkillMd({
+      name: packageName,
+      version,
+      releasedAt: resolved.releasedAt,
+      description: resolved.description,
+      dependencies: resolved.dependencies,
+      distTags: resolved.distTags,
+      body: cachedBody,
+      relatedSkills,
+      hasIssues: resources.hasIssues,
+      hasDiscussions: resources.hasDiscussions,
+      hasReleases: resources.hasReleases,
+      hasChangelog,
+      docsType: resources.docsType,
+      hasShippedDocs: shippedDocs,
+      pkgFiles,
+      generatedBy: 'cached',
+      dirName: skillDirName,
+      packages: allPackages.length > 1 ? allPackages : undefined,
+      repoUrl: resolved.repoUrl,
+      features,
+      eject: isEject,
+    })
+    writeFileSync(join(skillDir, 'SKILL.md'), skillMd)
+    p.log.success('Applied cached SKILL.md sections')
+  }
+
+  // Ask about LLM optimization (skip if -y flag, skipLlm config, sections cached, or model already specified)
   const globalConfig = readConfig()
-  if (!globalConfig.skipLlm && (!config.yes || config.model)) {
+  if (!allSectionsCached && !globalConfig.skipLlm && (!config.yes || config.model)) {
     const llmConfig = await selectLlmConfig(config.model)
     if (llmConfig?.promptOnly) {
       writePromptFiles({