test(registry): rewrite client tests for two-call resolve+detail flow

The old tests asserted a single GET /skills/<pkg>; the live API uses
POST /skills/resolve then GET /skills/<owner>/<repo>/<name>. Also
restores trailing-slash stripping on the base URL.

Author: harlan-zw

src/registry/client.ts

@@ -16,7 +16,7 @@ import { ofetch } from 'ofetch'
 const DEFAULT_REGISTRY_URL = 'https://skilld.dev/api'
 
 export function getRegistryBase(): string {
-  return process.env.SKILLD_REGISTRY_URL || DEFAULT_REGISTRY_URL
+  return (process.env.SKILLD_REGISTRY_URL || DEFAULT_REGISTRY_URL).replace(/\/$/, '')
 }
 
 export interface RegistrySkill {

test/unit/registry-client.test.ts

@@ -4,6 +4,31 @@ vi.mock('ofetch', () => ({
   ofetch: vi.fn(),
 }))
 
+function mockResolveAndDetail(ofetch: ReturnType<typeof vi.fn>, opts: {
+  packageName: string
+  owner?: string
+  repo?: string
+  raw?: string
+  pushedAt?: string
+}) {
+  const owner = opts.owner ?? 'antfu'
+  const repo = opts.repo ?? 'skills'
+  ofetch.mockResolvedValueOnce({
+    [opts.packageName]: { owner, repo, official: false },
+  })
+  ofetch.mockResolvedValueOnce({
+    owner,
+    repo,
+    name: opts.packageName,
+    displayName: opts.packageName,
+    installs: 1,
+    branch: 'main',
+    skillPath: `skills/${opts.packageName}/SKILL.md`,
+    raw: opts.raw ?? '# skill',
+    pushedAt: opts.pushedAt ?? '2026-01-01T00:00:00Z',
+  })
+}
+
 describe('registry client', () => {
   let originalUrl: string | undefined
 
@@ -22,52 +47,105 @@ describe('registry client', () => {
   it('fetchRegistrySkill uses default base when env unset', async () => {
     delete process.env.SKILLD_REGISTRY_URL
     const { ofetch } = await import('ofetch')
-    vi.mocked(ofetch).mockResolvedValueOnce({ name: 'vue-skilld', packageName: 'vue', version: '3.5.0', content: '# vue' })
+    mockResolveAndDetail(vi.mocked(ofetch), { packageName: 'vue' })
 
     const { fetchRegistrySkill } = await import('../../src/registry/client')
-    await fetchRegistrySkill('vue')
-
-    expect(ofetch).toHaveBeenCalledWith('https://skilld.dev/api/skills/vue')
+    const skill = await fetchRegistrySkill('vue')
+
+    expect(skill).not.toBeNull()
+    expect(ofetch).toHaveBeenNthCalledWith(1, 'https://skilld.dev/api/skills/resolve', {
+      method: 'POST',
+      body: { items: [{ packageName: 'vue', owner: undefined }] },
+    })
+    expect(ofetch).toHaveBeenNthCalledWith(2, 'https://skilld.dev/api/skills/antfu/skills/vue')
   })
 
   it('fetchRegistrySkill respects SKILLD_REGISTRY_URL override', async () => {
     process.env.SKILLD_REGISTRY_URL = 'http://localhost:3000/api'
     const { ofetch } = await import('ofetch')
-    vi.mocked(ofetch).mockResolvedValueOnce({ name: 'vue-skilld', packageName: 'vue', version: '3.5.0', content: '# vue' })
+    mockResolveAndDetail(vi.mocked(ofetch), { packageName: 'vue' })
 
     const { fetchRegistrySkill } = await import('../../src/registry/client')
     await fetchRegistrySkill('vue')
 
-    expect(ofetch).toHaveBeenCalledWith('http://localhost:3000/api/skills/vue')
+    expect(ofetch).toHaveBeenNthCalledWith(1, 'http://localhost:3000/api/skills/resolve', expect.any(Object))
+    expect(ofetch).toHaveBeenNthCalledWith(2, 'http://localhost:3000/api/skills/antfu/skills/vue')
   })
 
   it('strips trailing slash from override', async () => {
     process.env.SKILLD_REGISTRY_URL = 'http://localhost:3000/api/'
     const { ofetch } = await import('ofetch')
-    vi.mocked(ofetch).mockResolvedValueOnce({ name: 'vue-skilld', packageName: 'vue', version: '3.5.0', content: '# vue' })
+    mockResolveAndDetail(vi.mocked(ofetch), { packageName: 'vue' })
 
     const { fetchRegistrySkill } = await import('../../src/registry/client')
     await fetchRegistrySkill('vue')
 
-    expect(ofetch).toHaveBeenCalledWith('http://localhost:3000/api/skills/vue')
+    expect(ofetch).toHaveBeenNthCalledWith(1, 'http://localhost:3000/api/skills/resolve', expect.any(Object))
+  })
+
+  it('returns null when resolve fails', async () => {
+    const { ofetch } = await import('ofetch')
+    vi.mocked(ofetch).mockRejectedValueOnce(new Error('network'))
+
+    const { fetchRegistrySkill } = await import('../../src/registry/client')
+    expect(await fetchRegistrySkill('nonexistent')).toBeNull()
   })
 
-  it('returns null when registry fetch fails', async () => {
+  it('returns null when resolve has no hit', async () => {
     const { ofetch } = await import('ofetch')
-    vi.mocked(ofetch).mockRejectedValueOnce(new Error('404'))
+    vi.mocked(ofetch).mockResolvedValueOnce({})
 
     const { fetchRegistrySkill } = await import('../../src/registry/client')
     expect(await fetchRegistrySkill('nonexistent')).toBeNull()
+    expect(ofetch).toHaveBeenCalledTimes(1)
   })
 
-  it('encodes scoped package names', async () => {
+  it('returns null when detail has no raw SKILL.md', async () => {
+    const { ofetch } = await import('ofetch')
+    vi.mocked(ofetch)
+      .mockResolvedValueOnce({ vue: { owner: 'antfu', repo: 'skills', official: false } })
+      .mockResolvedValueOnce({ owner: 'antfu', repo: 'skills', name: 'vue', raw: null })
+
+    const { fetchRegistrySkill } = await import('../../src/registry/client')
+    expect(await fetchRegistrySkill('vue')).toBeNull()
+  })
+
+  it('passes scoped package names unencoded to resolve body', async () => {
     delete process.env.SKILLD_REGISTRY_URL
     const { ofetch } = await import('ofetch')
-    vi.mocked(ofetch).mockResolvedValueOnce({ name: 'nuxt-ui-skilld', packageName: '@nuxt/ui', version: '3.0.0', content: '# nuxt/ui' })
+    mockResolveAndDetail(vi.mocked(ofetch), { packageName: '@nuxt/ui', owner: 'nuxt', repo: 'ui' })
 
     const { fetchRegistrySkill } = await import('../../src/registry/client')
     await fetchRegistrySkill('@nuxt/ui')
 
-    expect(ofetch).toHaveBeenCalledWith('https://skilld.dev/api/skills/%40nuxt%2Fui')
+    expect(ofetch).toHaveBeenNthCalledWith(1, 'https://skilld.dev/api/skills/resolve', {
+      method: 'POST',
+      body: { items: [{ packageName: '@nuxt/ui', owner: undefined }] },
+    })
+    expect(ofetch).toHaveBeenNthCalledWith(2, 'https://skilld.dev/api/skills/nuxt/ui/@nuxt/ui')
+  })
+
+  it('maps detail payload into RegistrySkill', async () => {
+    const { ofetch } = await import('ofetch')
+    mockResolveAndDetail(vi.mocked(ofetch), {
+      packageName: 'vue',
+      owner: 'antfu',
+      repo: 'skills',
+      raw: '---\nname: vue\n---\n# vue',
+      pushedAt: '2026-03-16T06:16:24Z',
+    })
+
+    const { fetchRegistrySkill } = await import('../../src/registry/client')
+    const skill = await fetchRegistrySkill('vue')
+
+    expect(skill).toMatchObject({
+      name: 'vue',
+      packageName: 'vue',
+      owner: 'antfu',
+      repo: 'antfu/skills',
+      content: '---\nname: vue\n---\n# vue',
+      updatedAt: '2026-03-16T06:16:24Z',
+      branch: 'main',
+    })
   })
 })