[All] [1.21.10?] Race Condition During ClientSetup,

[Fealtous]

Describe the bug
FMLClientSetupEvent is multithreaded, which can cause issues such as this intermittently because the backing map is not thread safe.
Wrapping the render type initialization in FMLClientSetupEvent#enqueueWork should protect from intermittent crashes like this.

This issue likely affects all of the decor mods, though I only checked bridges and trapdoors. The fact that it's a race condition is also unhelpful for reproduction, but that's to be expected. If this is the case with prior versions of the Macaw decoration mods then they are also affected.

This issue was made on behalf of a user from the MinecraftForge discord support channels.

[sketchmacaw]

Hey, yeah I've recently found that I messed it up, this should be all to fix it right?
public static void onClientSetup(FMLClientSetupEvent event) { event.enqueueWork(() -> { ItemBlockRenderTypes.setRenderLayer(BlockInit.OAK_BARN_TRAPDOOR.get(), ChunkSectionLayer.CUTOUT); other stuff.... }); }

[sketchmacaw]

I really appreciate that you opened an issue and provided a fix for this, thanks.
( Trapdoors, Furniture, Lights, Holidays done, just marking )

[Fealtous]

Yes that should work just fine. I try to reach out to devs with issues when I can so you're very welcome.