msglist: Apply subscription color to StreamMessageRecipientHeader

Author: sirpengi

lib/widgets/message_list.dart

@@ -553,11 +553,19 @@ class StreamMessageRecipientHeader extends StatelessWidget {
 
     final topic = message.subject;
     final subscription = store.subscriptions[message.streamId];
-    final streamColor = Color(subscription?.color ?? 0x00c2c2c2);
-    final contrastingColor =
-      ThemeData.estimateBrightnessForColor(streamColor) == Brightness.dark
-        ? Colors.white
-        : Colors.black;
+    final Color backgroundColor;
+    final Color contrastingColor;
+    if (subscription != null) {
+      final swatch = subscription.colorSwatch();
+      backgroundColor = swatch.barBackground;
+      contrastingColor =
+        (ThemeData.estimateBrightnessForColor(swatch.barBackground) == Brightness.dark)
+          ? Colors.white
+          : Colors.black;
+    } else {
+      backgroundColor = _kFallbackStreamColor;
+      contrastingColor = Colors.black;
+    }
     final textStyle = TextStyle(
       color: contrastingColor,
     );
@@ -592,7 +600,7 @@ class StreamMessageRecipientHeader extends StatelessWidget {
         MessageListPage.buildRoute(context: context,
           narrow: TopicNarrow.ofMessage(message))),
       child: ColoredBox(
-        color: _kStreamMessageBorderColor,
+        color: backgroundColor,
         child: Row(mainAxisAlignment: MainAxisAlignment.start, children: [
           // TODO(#282): Long stream name will break layout; find a fix.
           streamWidget,
@@ -608,13 +616,11 @@ class StreamMessageRecipientHeader extends StatelessWidget {
           // TODO topic links?
           // Then web also has edit/resolve/mute buttons. Skip those for mobile.
           RecipientHeaderDate(message: message,
-            color: _kRecipientHeaderDateColor),
+            color: contrastingColor.withOpacity(0.4)),
         ])));
   }
 }
 
-final _kStreamMessageBorderColor = const HSLColor.fromAHSL(1, 0, 0, 0.88).toColor();
-
 class DmRecipientHeader extends StatelessWidget {
   const DmRecipientHeader({super.key, required this.message});
 

test/flutter_checks.dart

@@ -16,6 +16,10 @@ extension ClipboardDataChecks on Subject<ClipboardData> {
   Subject<String?> get text => has((d) => d.text, 'text');
 }
 
+extension ColoredBoxChecks on Subject<ColoredBox> {
+  Subject<Color?> get color => has((d) => d.color, 'color');
+}
+
 extension GlobalKeyChecks<T extends State<StatefulWidget>> on Subject<GlobalKey<T>> {
   Subject<BuildContext?> get currentContext => has((k) => k.currentContext, 'currentContext');
   Subject<Widget?> get currentWidget => has((k) => k.currentWidget, 'currentWidget');

test/widgets/message_list_test.dart

@@ -41,11 +41,13 @@ void main() {
     int? messageCount,
     List<Message>? messages,
     List<ZulipStream>? streams,
+    List<Subscription>? subscriptions,
     UnreadMessagesSnapshot? unreadMsgs,
   }) async {
     addTearDown(testBinding.reset);
+    streams ??= subscriptions;
     await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot(
-      streams: streams, unreadMsgs: unreadMsgs));
+      streams: streams, subscriptions: subscriptions, unreadMsgs: unreadMsgs));
     store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
     connection = store.connection as FakeApiConnection;
 
@@ -233,6 +235,20 @@ void main() {
         check(findInMessageList('stream name')).length.equals(0);
         check(findInMessageList('topic name')).length.equals(1);
       });
+
+      testWidgets('color of recipient header background', (tester) async {
+        final subscription = eg.subscription(stream, color: Colors.red.value);
+        final swatch = subscription.colorSwatch();
+        await setupMessageListPage(tester,
+          messages: [eg.streamMessage(stream: subscription)],
+          subscriptions: [subscription]);
+        await tester.pump();
+        check(tester.widget<ColoredBox>(
+          find.descendant(
+            of: find.byType(StreamMessageRecipientHeader),
+            matching: find.byType(ColoredBox),
+        ))).color.equals(swatch.barBackground);
+      });
     });
 
     testWidgets('show stream name from message when stream unknown', (tester) async {