KVM pings network gateway constantly

[apalrd]

It's unusual for a device to send a ping every 2sec continuously.

It's coming from chack_net_state() (

NanoKVM/support/kvm_system/main/lib/system_state/system_state.cpp

Line 146 in 97a9b37

int chack_net_state(ip_addr_t use_ip_type)

)

This is a terrible way to know if the network is 'up', and doesn't consider link-local networks which may not have a gateway, or IPv6.

[alexisfrjp]

It's also terrible to spot a bad practice without giving at least one solution. It's the best way to get ignored.

[apalrd]

the kernel already provides network state, it's stupid to implement this again in an app

[FlorianHeigl]

@alexisfrjp blameshifting, noone stops anyone who would like to fix this or design a product to first buy a few books on embedded development. we're here supporting it but if someone reports an issue for free for a product that is also developed for free the bargain is kept.

[gshpychka]

Was this solved by #307?