Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0 to add, 0 to remove, 0 unchanged should not be an error #15

Open
benley opened this issue Jan 21, 2025 · 0 comments
Open

0 to add, 0 to remove, 0 unchanged should not be an error #15

benley opened this issue Jan 21, 2025 · 0 comments

Comments

@benley
Copy link
Collaborator

benley commented Jan 21, 2025 

[2025-01-21 19:42:23 UTC INFO tailscale-manager] 0 to add, 0 to remove, 0 routes unchanged
[2025-01-21 19:42:23 UTC ERROR tailscale-manager] Sanity check failed! Refusing to apply changes!
[2025-01-21 19:42:23 UTC ERROR tailscale-manager] Shrink ratio: NaN

If there are 0 routes to manage, this probably should not fail the shrink ratio sanity check. Maybe it should be a different kind of error or warning, but not like this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benley