Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] SOMAArray/ManagedQuery refactor #3472

Open
johnkerl opened this issue Dec 18, 2024 · 2 comments
Open

[c++] SOMAArray/ManagedQuery refactor #3472

johnkerl opened this issue Dec 18, 2024 · 2 comments
Assignees
@nguyenv
Labels
cpp-api python-api r-api

Comments

@johnkerl
Copy link
Member

#3450 is a part, but, the end goal is that we completely remove ManagedQuery from SOMAArray.

To get there, we need to use ManagedQuery::read_next in Rcpp instead of SOMAArray::read_next.
This was referenced Dec 18, 2024
Merged
Merged
@johnkerl
Copy link
Member Author

@nguyenv is this completed?

@nguyenv
Copy link
Member

nguyenv commented Jan 17, 2025

No, only the read path has been refactored so far. We need to also refactor the write path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nguyenv nguyenv

Labels
cpp-api python-api r-api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnkerl @nguyenv