Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Show node version for JS-specific folders #528

Closed
d3lm opened this issue Feb 10, 2020 · 3 comments
Closed

[Feature Request] Show node version for JS-specific folders #528

d3lm opened this issue Feb 10, 2020 · 3 comments

Comments

@d3lm
Copy link

d3lm commented Feb 10, 2020

It would be great if we could also show the node version only for JS-specific folders that maybe contain a package.json or node_modules. When switching the working tree the information in the prompt should be updated accordingly. Here's an example of what I am imagining:

image

I have implemented this locally and would be willing to send my changes as a PR. However, I am not sure if it's the proper way of implementing it because I personally don't have that much experience with bash programming. But I'd love to get this in and get your feedback on my implementation. I was mostly inspired by how the git stuff is done asynchronously.

@sindresorhus
Copy link
Owner

Yeah, would be useful. We're looking into how to be able to do this in a more modular way to make it easier for people to enable/disable certain part, like this and even make their own: #460

@sindresorhus
Copy link
Owner

Duplicate of #503

@sindresorhus sindresorhus marked this as a duplicate of #503 Feb 13, 2020
@sindresorhus
Copy link
Owner

^ You should comment there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants