Skip to content
This repository was archived by the owner on Jan 23, 2021. It is now read-only.

Commit f803e52

Browse files
author
Rob Wierzbowski
committed
Tighten up sourcemap logic
1 parent 570e64f commit f803e52

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

index.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,33 +30,33 @@ function newErr (err, opts) {
3030
}
3131

3232
// for now, source is only a single directory or a single file
33-
// TODO: implement glob source
3433
module.exports = function (source, options) {
3534
var stream = new Readable({objectMode: true});
3635
var cwd = process.cwd();
36+
var defaults = {
37+
container: 'gulp-ruby-sass',
38+
verbose: false,
39+
sourcemap: false
40+
};
3741
var command;
3842
var args;
3943
var base;
4044
var destDir;
4145
var destFile;
4246
var compileMappings;
43-
var defaults = {
44-
container: 'gulp-ruby-sass',
45-
verbose: false
46-
};
4747

4848
// redundant but necessary
4949
stream._read = function () {};
5050

5151
options = assign(defaults, options);
5252

5353
// sourcemap can only be true or false; warn those trying to pass a Sass string option
54-
if (typeof options.sourcemap === 'string') {
54+
if (typeof options.sourcemap !== 'boolean') {
5555
throw newErr('The sourcemap option must be true or false. See the readme for instructions on using Sass sourcemaps with gulp.');
5656
}
5757

58-
// reassign options.sourcemap boolean to our two acceptable Sass arguments
59-
options.sourcemap = options.sourcemap ? 'file' : 'none';
58+
// reassign options.sourcemap boolean to one of our two acceptable Sass arguments
59+
options.sourcemap = options.sourcemap === true ? 'file' : 'none';
6060

6161
// sass options need unix style slashes
6262
destDir = slash(path.join(osTempDir, options.container));

0 commit comments

Comments
 (0)