Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lazy memory management #5

Open
simondemeule opened this issue Sep 27, 2020 · 0 comments
Open

Fix lazy memory management #5

simondemeule opened this issue Sep 27, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@simondemeule
Copy link
Owner

simondemeule commented Sep 27, 2020 •
edited
Loading

At the moment, BoundedHierarchy's BoundedNodes, andRenderData's MeshDatas, MeshInstances, Lights, ShadableObjects, Fields and Camera` are raw pointers that are never properly deleted upon destruction of the "owner" object (which don't have explicitly defined destructors either). This isn't a performance issue since these things are only created once at the start of the program, but it is terrible practice.
@simondemeule simondemeule added the bug Something isn't working label Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simondemeule