Skip to content

Commit fdc35d0

Browse files
Donny9xiaoxiang781216
authored andcommitted
examples/elf: remove unnecessary config CONFIG_EXAMPLES_ELF_DEVPATH
Signed-off-by: dongjiuzhu1 <[email protected]>
1 parent a551612 commit fdc35d0

File tree

1 file changed

+19
-22
lines changed

1 file changed

+19
-22
lines changed

examples/elf/elf_main.c

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -62,21 +62,17 @@
6262
# error "You must not disable mountpoints via CONFIG_DISABLE_MOUNTPOINT in your configuration file"
6363
#endif
6464

65+
#ifndef CONFIG_EXAMPLES_ELF_DEVMINOR
66+
# define CONFIG_EXAMPLES_ELF_DEVMINOR 0
67+
#endif
68+
6569
#if defined(CONFIG_EXAMPLES_ELF_ROMFS)
6670
/* Describe the ROMFS file system */
6771

6872
# define SECTORSIZE 512
6973
# define NSECTORS(b) (((b) + SECTORSIZE - 1) / SECTORSIZE)
7074
# define MOUNTPT "/mnt/romfs"
7175

72-
# ifndef CONFIG_EXAMPLES_ELF_DEVMINOR
73-
# define CONFIG_EXAMPLES_ELF_DEVMINOR 0
74-
# endif
75-
76-
# ifndef CONFIG_EXAMPLES_ELF_DEVPATH
77-
# define CONFIG_EXAMPLES_ELF_DEVPATH "/dev/ram0"
78-
# endif
79-
8076
#elif defined(CONFIG_EXAMPLES_ELF_CROMFS)
8177
/* Describe the CROMFS file system */
8278

@@ -106,6 +102,8 @@
106102
# define errmsg printf
107103
#endif
108104

105+
#define ELF_DEVPATH_FMT "/dev/ram%d"
106+
109107
/****************************************************************************
110108
* Private Data
111109
****************************************************************************/
@@ -200,6 +198,7 @@ static inline void testheader(FAR const char *progname)
200198

201199
int main(int argc, FAR char *argv[])
202200
{
201+
char devname[32];
203202
#ifdef CONFIG_EXAMPLES_ELF_FSREMOVEABLE
204203
struct stat buf;
205204
#endif
@@ -214,6 +213,8 @@ int main(int argc, FAR char *argv[])
214213

215214
mm_initmonitor();
216215

216+
sprintf(devname, ELF_DEVPATH_FMT, CONFIG_EXAMPLES_ELF_DEVMINOR);
217+
217218
#if defined(CONFIG_EXAMPLES_ELF_ROMFS)
218219

219220
/* Create a ROM disk for the ROMFS filesystem */
@@ -238,14 +239,13 @@ int main(int argc, FAR char *argv[])
238239
/* Mount the ROMFS file system */
239240

240241
message("Mounting ROMFS filesystem at target=%s with source=%s\n",
241-
MOUNTPT, CONFIG_EXAMPLES_ELF_DEVPATH);
242+
MOUNTPT, devname);
242243

243-
ret = mount(CONFIG_EXAMPLES_ELF_DEVPATH, MOUNTPT, "romfs",
244-
MS_RDONLY, NULL);
244+
ret = mount(devname, MOUNTPT, "romfs", MS_RDONLY, NULL);
245245
if (ret < 0)
246246
{
247247
errmsg("ERROR: mount(%s,%s,romfs) failed: %s\n",
248-
CONFIG_EXAMPLES_ELF_DEVPATH, MOUNTPT, strerror(errno));
248+
devname, MOUNTPT, strerror(errno));
249249
}
250250

251251
#elif defined(CONFIG_EXAMPLES_ELF_CROMFS)
@@ -268,27 +268,26 @@ int main(int argc, FAR char *argv[])
268268

269269
do
270270
{
271-
ret = stat(CONFIG_EXAMPLES_ELF_DEVPATH, &buf);
271+
ret = stat(devname, &buf);
272272
if (ret < 0)
273273
{
274274
int errcode = errno;
275275
if (errcode == ENOENT)
276276
{
277-
printf("%s does not exist. Waiting...\n",
278-
CONFIG_EXAMPLES_ELF_DEVPATH);
277+
printf("%s does not exist. Waiting...\n", devname);
279278
sleep(1);
280279
}
281280
else
282281
{
283282
printf("ERROR: stat(%s) failed: %s Aborting...\n",
284-
CONFIG_EXAMPLES_ELF_DEVPATH, strerror(errcode));
283+
devname, strerror(errcode));
285284
exit(EXIT_FAILURE);
286285
}
287286
}
288287
else if (!S_ISBLK(buf.st_mode))
289288
{
290289
printf("ERROR: stat(%s) exists but is not a block driver: %04x\n",
291-
CONFIG_EXAMPLES_ELF_DEVPATH, buf.st_mode);
290+
devname, buf.st_mode);
292291
exit(EXIT_FAILURE);
293292
}
294293
}
@@ -300,13 +299,11 @@ int main(int argc, FAR char *argv[])
300299
message("Mounting %s filesystem at target=%s\n",
301300
CONFIG_EXAMPLES_ELF_FSTYPE, MOUNTPT);
302301

303-
ret = mount(CONFIG_EXAMPLES_ELF_DEVPATH, MOUNTPT,
304-
CONFIG_EXAMPLES_ELF_FSTYPE, MS_RDONLY, NULL);
302+
ret = mount(devname, MOUNTPT, CONFIG_EXAMPLES_ELF_FSTYPE, MS_RDONLY, NULL);
305303
if (ret < 0)
306304
{
307-
errmsg("ERROR: mount(%s, %s, %s) failed: %s\n",
308-
CONFIG_EXAMPLES_ELF_DEVPATH, CONFIG_EXAMPLES_ELF_FSTYPE,
309-
MOUNTPT, strerror(errno));
305+
errmsg("ERROR: mount(%s, %s, %s) failed: %s\n", devname,
306+
CONFIG_EXAMPLES_ELF_FSTYPE, MOUNTPT, strerror(errno));
310307
}
311308
#endif
312309
#else

0 commit comments

Comments
 (0)