-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1.0] Debian build and how to skip ascent downloading ? #4115
Comments
Hi, Here are a couple of options I can come up with:
Let me know what you think of those approaches. |
I will discuss with the scipy/pooch maintainer in order to find a solution to this problem.
thanks a lot
Fred
----- Le 2 Mai 24, à 10:16, Thomas VINCENT ***@***.*** a écrit :
Hi,
Here are a couple of options I can come up with:
- If `scipy` is not installed, those tests will be skipped (but other tests will
also be skipped). Is it easy to do so in the packaging config?
not that simple since the dependencies are automatically computed from packages installed in the chroot during the build. So I need to install scipy in order to have the correct dependencies.
This computation is done via dh-python3.
I can indeed un-activate the test during the build and run them only via the CI... but I prefer to have an early failure during the build in order to avoid uploading a broken package.
- Otherwise, is it possible to copy the
[ascent.dat](https://raw.githubusercontent.com/scipy/dataset-ascent/main/ascent.dat)
in the packaging repo and then copy it to
`/builds/science-team/silx/debian/output/source_dir/.pybuild/cpython3_3.11_silx/.cache/scipy-data/`?
The `pooch` package used by `scipy` would then find it.
This doesn not seems a resonable solution, but maybe providing a dedicated package with the data files expected by scipy could, would possible.
I do not know the size of these datasets... Debian-science could be the place to discuss about this.
- I don't know what is the usual Debian way, but the `scipy` packaging could
also embed the data files: The cache folder can be changed by patching the
following line in `scipy`:
https://github.com/scipy/scipy/blob/c0fa9e36168c24ce6772e054653c82c73e083d56/scipy/datasets/_fetchers.py#L14
That would be a generic way to fix it.
yes :)
- Finally, we could also embed the `ascent.dat` file in `silx` (it's "public
domain"), but that would be for another release.
I think that it is a bad idea :)). :p
I will put this on my TODO list :).
once again. Thanks a lot.
Fred
|
Fully agreed! That was my last option ;)
You're welcome, and thanks a lot for all the packaging effort! |
I'm closing this issue since it looks to have been fixed in the Debian packaging project: https://salsa.debian.org/science-team/silx/-/commit/31d61a4b6a375f545472c5e2580f6b0889b73ba7 Please reopen if needed |
Hello, while preparing the Debian package of silx.
I have this failure.
'''
Downloading file 'ascent.dat' from 'https://raw.githubusercontent.com/scipy/dataset-ascent/main/ascent.dat' to '/builds/science-team/silx/debian/output/source_dir/.pybuild/cpython3_3.11_silx/.cache/scipy-data'.
'''
the full log is here.
https://salsa.debian.org/science-team/silx/-/jobs/5622288
is it possible to skip these test easily ?
For security reason, it is not allow to have network connetion during a Debian build.
thanks for your advices.
Fred
The text was updated successfully, but these errors were encountered: