Show notice when custom configurations apply to the draft

Author: RaymondLuong3

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-projects.component.html

@@ -3,10 +3,10 @@
     <mat-label>Filter projects...</mat-label>
     <input matInput (keyup)="updateSearchTerm($event.target)" id="project-filter" />
   </mat-form-field>
+  <mat-checkbox [(ngModel)]="showProjectsWithCustomServalConfig" (change)="updateServalConfigFilter()">
+    Projects with custom Serval Configuration only
+  </mat-checkbox>
 </div>
-<mat-checkbox [(ngModel)]="showProjectsWithCustomServalConfig" (change)="updateServalConfigFilter()"
-  >Projects with custom serval configs only</mat-checkbox
->
 @if (!isLoading) {
   @if (length > 0) {
     <table mat-table id="projects-table" [dataSource]="rows">

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-projects.component.scss

@@ -12,3 +12,9 @@ mat-form-field {
   gap: 4px;
   white-space: nowrap;
 }
+
+.projects-controls {
+  display: flex;
+  align-items: center;
+  justify-content: space-between;
+}

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/_draft-generation-steps-theme.scss

@@ -8,8 +8,6 @@
   --mat-stepper-header-icon-foreground-color: #{mat.get-theme-color($theme, neutral, if($is-dark, 90, 98))};
   --mat-stepper-header-edit-state-icon-background-color: #{mat.get-theme-color($theme, primary, if($is-dark, 30, 10))};
   --mat-stepper-header-edit-state-icon-foreground-color: #{mat.get-theme-color($theme, neutral, if($is-dark, 90, 98))};
-  --mat-stepper-link-color: #{mat.get-theme-color($theme, primary, if($is-dark, 60, 50))};
-  --mat-stepper-link-hover-color: #{mat.get-theme-color($theme, primary, if($is-dark, 70, 60))};
 }
 
 @mixin theme($theme) {

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.html

@@ -307,16 +307,6 @@ <h2>
           <div class="confirm-translate confirm-books">
             {{ selectedTranslateBooksAsString() }}
           </div>
-          @if (servalConfig != null) {
-            <div class="serval-config-toggle">
-              <u (click)="showCustomConfig = !showCustomConfig">{{
-                showCustomConfig ? t("hide_custom_serval_config") : t("show_custom_config")
-              }}</u>
-            </div>
-            @if (showCustomConfig) {
-              <pre class="custom-config">{{ servalConfig | json }}</pre>
-            }
-          }
         </mat-card>
         <h2>{{ t("summary_notifications") }}</h2>
         @if (currentUserEmail != null) {
@@ -328,6 +318,11 @@ <h2>{{ t("summary_notifications") }}</h2>
             </div>
           </mat-card>
         }
+        @if (isCustomConfigSet) {
+          <app-notice icon="info" type="info">
+            {{ t("custom_configurations_apply") }}
+          </app-notice>
+        }
 
         <div class="button-strip">
           <button mat-stroked-button matStepperPrevious>

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.scss

@@ -159,11 +159,3 @@ app-notice {
   --mat-table-row-item-outline-width: 0;
   padding-top: 16px;
 }
-
-.serval-config-toggle {
-  color: var(--mat-stepper-link-color);
-  :hover {
-    cursor: pointer;
-    color: var(--mat-stepper-link-hover-color);
-  }
-}

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.spec.ts

@@ -1359,8 +1359,8 @@ describe('DraftGenerationStepsComponent', () => {
       expect(trainingGroups[1].ranges[1]).toEqual('1 Samuel');
     });
 
-    it('records the custom serval config', () => {
-      expect(component['servalConfig']).toEqual('{ "custom": "value" }');
+    it('sets the custom serval config flag', () => {
+      expect(component['isCustomConfigSet']).toEqual(true);
     });
   });
 

src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-generation-steps/draft-generation-steps.component.ts

@@ -1,4 +1,3 @@
-import { JsonPipe } from '@angular/common';
 import { Component, DestroyRef, EventEmitter, OnInit, Output, ViewChild } from '@angular/core';
 import { FormsModule } from '@angular/forms';
 import { MatButton } from '@angular/material/button';
@@ -117,8 +116,7 @@ interface ProjectPendingUpdate {
     TranslocoModule,
     TranslocoMarkupModule,
     BookMultiSelectComponent,
-    ConfirmSourcesComponent,
-    JsonPipe
+    ConfirmSourcesComponent
   ]
 })
 export class DraftGenerationStepsComponent implements OnInit {
@@ -153,7 +151,6 @@ export class DraftGenerationStepsComponent implements OnInit {
   expandUnusableTranslateBooks = false;
   expandUnusableTrainingBooks = false;
   isStepsCompleted = false;
-  showCustomConfig = false;
 
   protected nextClickedOnLanguageVerification = false;
   protected hasLoaded = false;
@@ -162,7 +159,7 @@ export class DraftGenerationStepsComponent implements OnInit {
   protected trainingSources: DraftSource[] = [];
   protected trainingTargets: DraftSource[] = [];
   protected trainingDataFiles: Readonly<TrainingData>[] = [];
-  protected servalConfig?: string;
+  protected isCustomConfigSet = false;
 
   private trainingDataQuery?: RealtimeQuery<TrainingDataDoc>;
   private trainingDataQuerySubscription?: Subscription;
@@ -293,7 +290,7 @@ export class DraftGenerationStepsComponent implements OnInit {
             // See if there is an existing training scripture range
             const draftConfig: DraftConfig | undefined =
               this.activatedProject.projectDoc?.data?.translateConfig.draftConfig;
-            this.servalConfig = draftConfig?.servalConfig;
+            this.isCustomConfigSet = draftConfig?.servalConfig != null;
             const hasPreviousTrainingRange: boolean =
               (draftConfig?.lastSelectedTrainingScriptureRanges ?? []).length > 0;
 

src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json

@@ -242,11 +242,11 @@
     "configure_advanced_settings_header": "Advanced",
     "configure_advanced_settings_title": "Advanced settings",
     "confirm_codes_correct_to_continue": "Please confirm the language codes are correct before continuing",
+    "custom_configurations_apply": "Custom draft configurations have been applied by an administrator.",
     "email_me": "Email me at {{ email }} when the draft is finished.",
     "fast_training_warning": "Enabling this will save time but greatly reduce accuracy.",
     "fast_training": "Enable Fast Training",
     "generate_draft": "Generate draft",
-    "hide_custom_serval_config": "Hide custom serval configuration",
     "loading": "Loading...",
     "loading_projects": "Loading project sync status...",
     "next": "Next",
@@ -257,7 +257,6 @@
     "reference_books": "Reference books",
     "remote_changes": "The source configuration for draft generation has been modified. Please start a new draft and review the latest source configuration.",
     "remote_changes_start_over": "Start over",
-    "show_custom_config": "Show custom serval configuration",
     "summary_header": "Summary",
     "summary_notifications": "Notifications",
     "summary_title": "Summary",