SF-3650 Correctly specify the target filters for the trainon config (#3580)

Author: pmachapman

src/SIL.XForge.Scripture/Services/MachineProjectService.cs

@@ -1271,15 +1271,27 @@ .. corporaSyncInfo
                             .Select(s => new ParallelCorpusFilterConfig
                             {
                                 CorpusId = s.CorpusId,
-                                ScriptureRange = buildConfig
-                                    .TrainingScriptureRanges.FirstOrDefault(t => t.ProjectId == s.ProjectId)
-                                    ?.ScriptureRange,
+                                // NOTE: The scripture range will be set to match the matching source filter's scripture range below
                             }),
                     ],
                 },
             ],
         };
 
+        // Set the training target filter scripture ranges to the same as the source filter scripture ranges
+        foreach (TrainingCorpusConfig trainingCorpusConfig in translationBuildConfig.TrainOn)
+        {
+            for (int j = 0; j < trainingCorpusConfig.SourceFilters?.Count; j++)
+            {
+                if (trainingCorpusConfig.TargetFilters?[j] is not null)
+                {
+                    trainingCorpusConfig.TargetFilters[j].ScriptureRange = trainingCorpusConfig
+                        .SourceFilters[j]
+                        .ScriptureRange;
+                }
+            }
+        }
+
         // Add the additional training data
         if (
             !string.IsNullOrWhiteSpace(servalData.AdditionalTrainingData?.ParallelCorpusId)

test/SIL.XForge.Scripture.Tests/Services/MachineProjectServiceTests.cs

@@ -1908,7 +1908,6 @@ public void GetTranslationBuildConfig_TranslationScriptureRangesAndTrainingScrip
         const string project01ScriptureRange = "MAT;MRK";
         // No scripture range is supported for target pre-translate translation (project02)
         const string project03ScriptureRange = "LUK;JHN";
-        const string project04ScriptureRange = "ACT;ROM";
         var buildConfig = new BuildConfig
         {
             TranslationScriptureRanges =
@@ -1918,7 +1917,6 @@ public void GetTranslationBuildConfig_TranslationScriptureRangesAndTrainingScrip
             TrainingScriptureRanges =
             [
                 new ProjectScriptureRange { ProjectId = Project03, ScriptureRange = project03ScriptureRange },
-                new ProjectScriptureRange { ProjectId = Project04, ScriptureRange = project04ScriptureRange },
             ],
         };
         List<ServalCorpusSyncInfo> corporaSyncInfo =
@@ -1949,7 +1947,7 @@ public void GetTranslationBuildConfig_TranslationScriptureRangesAndTrainingScrip
                 CorpusId = Corpus04,
                 IsSource = false,
                 ParallelCorpusId = ParallelCorpus02,
-                ProjectId = Project04,
+                ProjectId = Project02,
             },
         ];
 
@@ -1975,7 +1973,7 @@ public void GetTranslationBuildConfig_TranslationScriptureRangesAndTrainingScrip
                 .ScriptureRange
         );
         Assert.AreEqual(
-            project04ScriptureRange,
+            project03ScriptureRange,
             actual
                 .TrainOn!.Single(c => c.ParallelCorpusId == ParallelCorpus02)
                 .TargetFilters!.Single(f => f.CorpusId == Corpus04)