Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key terms English glosses are pulled regardless of source text #630

Open
bhartmoore opened this issue Jan 17, 2025 · 1 comment
Open

Key terms English glosses are pulled regardless of source text #630

bhartmoore opened this issue Jan 17, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bhartmoore
Copy link
Collaborator

It appears that in silnlp training, English key terms glosses are being used when French or Indonesian glosses should be used. (Likely also affecting Spanish and Portuguese, but I haven't tested.) Entries from train.src.detok.txt (screenshot 1) are clearly English and don't match words in silnlp\assets\fr-Major-glosses.txt (screenshot 2).

Some examples are in the following folders:

S:\MT\experiments\Chad\Mukulu\fr_mix_moz_1
S:\MT\experiments\FT-Benin\NLLB.1.3B.dist.fr_LBS21+DDN2BT-ddn_DDN2_Terms
S:\MT\experiments\FT-Indonesian2\NLLB1.3B.id_TBI+DAABT-kzfDAAU8_Terms

Image

Image

@bhartmoore bhartmoore added the bug Something isn't working label Jan 17, 2025
@Enkidu93
Copy link
Collaborator

Enkidu93 commented Jan 17, 2025

Looks like the silnlp.common.corpus:get_terms() function has "en" as the default iso parameter (maybe it shouldn't have a default iso at all?), and the proper iso isn't being passed when it's called in silnlp.nmt.config line 1101 & 1105. This shouldn't affect Serval.

@TaperChipmunk32 TaperChipmunk32 self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants