normal notifications, no reviewer email notifications

Author: James-Voight

src/lib/server/job-executors/system.ts

@@ -902,6 +902,7 @@ async function tryCreateInstance(
           includeFields: [],
           includeArtifacts: null,
           includeReviewers: false,
+          isAutomatic: false,
           environment: mergedEnv,
           start: ActivityName as WorkflowState
         } satisfies WorkflowInstanceContext),

src/lib/server/workflow/dbProcedures.ts

@@ -1,7 +1,7 @@
 import { ProductTransitionType } from '../../prisma';
+import { BullMQ, getQueues } from '../bullmq';
 import { DatabaseWrites } from '../database';
 import { DatabaseReads } from '../database/prisma';
-import { BullMQ, getQueues } from '../bullmq';
 
 export async function deleteWorkflow(productId: string) {
   const product = await DatabaseReads.products.findUnique({

src/lib/server/workflow/state-machine.ts

@@ -14,9 +14,9 @@ import {
   WorkflowAction,
   WorkflowOptions,
   WorkflowState,
+  autoPublishOnRebuild,
   hasAuthors,
   hasReviewers,
-  autoPublishOnRebuild,
   isAuthorState,
   isDeprecated,
   jump
@@ -712,50 +712,39 @@ export const WorkflowStateMachine = setup({
       }
     },
     [WorkflowState.Verify_and_Publish]: {
-      entry: [
-        assign({
-          instructions: ({ context }) => {
-            switch (context.productType) {
-              case ProductType.Android_GooglePlay:
-                return 'googleplay_verify_and_publish';
-              case ProductType.Android_S3:
-                return 'verify_and_publish';
-              case ProductType.AssetPackage:
-                return 'asset_package_verify_and_publish';
-              case ProductType.Web:
-                return 'web_verify';
-            }
-          },
-          includeFields: ({ context }) => {
-            switch (context.productType) {
-              case ProductType.Android_GooglePlay:
-              case ProductType.Android_S3:
-                return ['storeDescription', 'listingLanguageCode'];
-              case ProductType.AssetPackage:
-              case ProductType.Web:
-                return ['storeDescription'];
-            }
-          },
-          includeReviewers: true,
-          includeArtifacts: ({ context }) => {
-            switch (context.productType) {
-              case ProductType.AssetPackage:
-                return 'latestAssetPackage';
-              default:
-                return 'all';
-            }
+      entry: assign({
+        instructions: ({ context }) => {
+          switch (context.productType) {
+            case ProductType.Android_GooglePlay:
+              return 'googleplay_verify_and_publish';
+            case ProductType.Android_S3:
+              return 'verify_and_publish';
+            case ProductType.AssetPackage:
+              return 'asset_package_verify_and_publish';
+            case ProductType.Web:
+              return 'web_verify';
           }
-        }),
-        ({ context }) => {
-          if (!context.isAutomatic) {
-            return;
+        },
+        includeFields: ({ context }) => {
+          switch (context.productType) {
+            case ProductType.Android_GooglePlay:
+            case ProductType.Android_S3:
+              return ['storeDescription', 'listingLanguageCode'];
+            case ProductType.AssetPackage:
+            case ProductType.Web:
+              return ['storeDescription'];
+          }
+        },
+        includeReviewers: true,
+        includeArtifacts: ({ context }) => {
+          switch (context.productType) {
+            case ProductType.AssetPackage:
+              return 'latestAssetPackage';
+            default:
+              return 'all';
           }
-          void getQueues().Emails.add(`Email reviewers for Product #${context.productId}`, {
-            type: BullMQ.JobType.Email_SendNotificationToReviewers,
-            productId: context.productId
-          });
         }
-      ],
+      }),
       exit: assign({
         includeReviewers: false,
         includeArtifacts: null