Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce compile-time memory usage #162

Closed
sieren opened this issue Sep 11, 2016 · 6 comments · Fixed by #167
Closed

Reduce compile-time memory usage #162

sieren opened this issue Sep 11, 2016 · 6 comments · Fixed by #167

Comments

@sieren
Copy link
Owner

sieren commented Sep 11, 2016

Reduce compile-time memory usage by separating out the animated gifs into different qrc files.
#157 (comment)

@vext01
Copy link

vext01 commented Sep 11, 2016

Thanks for this.

@sieren
Copy link
Owner Author

sieren commented Oct 9, 2016

ping @vext01 - I moved those files into separate QRC files. I hope this reduces compile time memory usage. Mind giving it a shot?

@sieren sieren reopened this Oct 9, 2016
@sieren
Copy link
Owner Author

sieren commented Oct 26, 2016

Any update before I close this?

@mulander
Copy link

@sieren hi, sorry for not getting back earlier. I'll test this in an hour or so.

@mulander
Copy link

I just re-tested the version we tried in September (v0.5.2) and did a fresh test of v0.5.5rc1 just now.

v0.5.2:
Killed by the operating system for exceeding memory quota which is 1536 M.

v0.5.5rc1:
Build successfully and the peak memory usage observed via top was ~700 M. That peak happened twice and lasted for less than 3 seconds, most of the build hovers between 300-400 M of RES memory.

Obviously there are more changes than just the GIF being moved out in the version I tested so I can't guarantee that this change has been the exact fix.

All in all I consider this fixed.

@sieren
Copy link
Owner Author

sieren commented Oct 26, 2016

@mulander thanks for testing. Yeah, I'm quite sure this is responsible for the fix though as I experienced similar issues on AppVeyor before with MSVC running out of memory on the QRC files containing the gifs. This hasnt happened since either.

@sieren sieren closed this as completed Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants