-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce compile-time memory usage #162
Comments
Thanks for this. |
ping @vext01 - I moved those files into separate QRC files. I hope this reduces compile time memory usage. Mind giving it a shot? |
Any update before I close this? |
@sieren hi, sorry for not getting back earlier. I'll test this in an hour or so. |
I just re-tested the version we tried in September (v0.5.2) and did a fresh test of v0.5.5rc1 just now. v0.5.2: v0.5.5rc1: Obviously there are more changes than just the GIF being moved out in the version I tested so I can't guarantee that this change has been the exact fix. All in all I consider this fixed. |
@mulander thanks for testing. Yeah, I'm quite sure this is responsible for the fix though as I experienced similar issues on AppVeyor before with MSVC running out of memory on the QRC files containing the gifs. This hasnt happened since either. |
Reduce compile-time memory usage by separating out the animated gifs into different
qrc
files.#157 (comment)
The text was updated successfully, but these errors were encountered: