Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist theme in localstrorage #91

Open
jsrikrishna11 opened this issue May 16, 2020 · 4 comments
Open

Persist theme in localstrorage #91

jsrikrishna11 opened this issue May 16, 2020 · 4 comments
Assignees

Comments

@jsrikrishna11
Copy link

jsrikrishna11 commented May 16, 2020

After choosing a theme other than the default theme which is 'light'. If I refresh the page, the page theme is being reset to 'light'. This is because, on reload it is calling useState('light')again.

Is it even an issue?

@rubenmoya
Copy link
Collaborator

rubenmoya commented May 18, 2020

It would be nice if it kept the configuration that the user chose.

Go for it!

@iamdarshshah
Copy link
Contributor

Yes, We can store the current theme in local-storage (when a user visits the website it will be set tolight by default) and we can update it as per the user convenience.

Thus, When a user visits the site theme will be set as per the user's selected theme (by default it will be set to light).

@jsrikrishna11
Copy link
Author

I would like to work on it, unless some else took it up. Let me know :)

@siddharthkp
Copy link
Owner

@jsrikrishna11 Go for it :)

@siddharthkp siddharthkp changed the title Documentation issue: Theme application consistency Persist theme in localstrorage May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants