-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repository hosting platform #7
Comments
Passing the platform makes more sense to me 🙂 |
@siddharthkp - one quick question. The generic environment variables for |
I don't think it's useful to use repo url, platform would be better (example: github, gitlab, bitbucket, etc.) So in the case of custom, it would be |
Sorry, I didn't put my question correctly. Actually most of CI platforms provide repo url environment variable and i'm thinking of extracting the platform using regular expression. So I asked for the |
Ah, understood! I think in custom CI, we follow the rule of directly asking for the information we need. So it makes more sense to ask for ci platform rather than ask for URL and then infer it. |
Yes, I think that will be good idea. Thanks |
Coming from here siddharthkp/bundlesize#158 I checked if we can get the platform where the repository is actually hosted.
Travis : From here we can conclude that Travis supports only github.com.
Circle : There's an env variable
CIRCLE_REPOSITORY_URL
. Check here.Wercker : They have
WERCKER_GIT_DOMAIN
. Check hereDrone : I'm not sure between
DRONE_REMOTE_URL
andDRONE_REPO_LINK
. Check here.We can either send repo url or the name of the hosting platform.
The text was updated successfully, but these errors were encountered: