-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Diff budgeting in addition to maxSize budget #365
Comments
Can you tell me a little more about diff budgets? What would that look like? |
Currently we have maxSize budgets,
In any product, each module will incrementally be worked upon. So over a period of pull request merges, the maxSize budget will be breached. So if we can also setup a budget on the increase in size that can be allowed per request,
We would be able to control things at a granular level. This will also help capture bulk increases in the asset. ie, a maxSize of 30kb will not be able to capture a dependency change that brings in a 5kb increase in size on a 23kb asset. but a 1kb diffSize will easily capture these anomalies. |
So you believe that gradually reaching a 15MB bloat is somehow better than at once? :p |
Nope. 'In addition to the overall size is the crux here'
Whoah its been 3 years 😅 |
Oh, I didn't notice the issue date, or last commit date 😄 I just ran ...
... and wanted to see if only I am bothered by the result. |
Do you want to request a feature or report a bug?
Feature
If this is a feature request, what is motivation or use case for changing the behavior?
While we can currently setup maxSize budgets for file patterns, periodic incremental changes will end up breaching the budget.
So can we also consider implementing diff budgets?
Please mention other relevant information.
The text was updated successfully, but these errors were encountered: