Unexpected exit status when token is provided

[weynsee]

Do you want to request a feature or report a bug?
Report a possible bug

What is the current behavior?
When token is provided bundlesize still exits with 0 status even if the checks fail.

If the current behavior is a bug, please provide the steps to reproduce.

• Create project with a failing bundlesize check
• Integrate with CI and supply a token
• Configure CI to run build with bundlesize

What is the expected behavior?
If CI uses exit status code to verify build status, then the build should fail, but currently it does not.

Please mention other relevant information.

• node version: 8.9.4
• npm version: 3.10.8
• Operating system: N/A
• bundlesize version: 0.17.0
• CI you are using: TravisCI

[palashmon]

Hi, thanks for reporting this but this issue is not clear to me. Do you mean like your CI build failed but bundlesize still passed?

[weynsee]

Actually the CI build passed even though bundlesize failed. When I run bundlesize and the bundle size exceeds the max limit, it exits with an exit status of 0 so the CI sees it as a successful build. This only happens when CI integration is enabled. Is this expected behaviour?

[palashmon]

cc @siddharthkp

[weynsee]

I created a quick PR here to hopefully better illustrate the problem I'm encountering (and a possible bug fix). Feel free to close it if the current behaviour is expected, thanks!

[oliverviljamaa]

We are seeing similar behaviour.