Merge pull request #30 from shotstack/remove-strict-fps

jeffski · web-flow · commit 750da9149062 · 2023-10-03T10:52:04.000+10:00
Fix FPS strict check which is confused by double and integer
diff --git a/src/Model/Output.php b/src/Model/Output.php
@@ -609,7 +609,7 @@ public function getFps()
     public function setFps($fps)
     {
         $allowedValues = $this->getFpsAllowableValues();
-        if (!is_null($fps) && !in_array($fps, $allowedValues, true)) {
+        if (!is_null($fps) && !in_array($fps, $allowedValues, false)) {
             throw new \InvalidArgumentException(
                 sprintf(
                     "Invalid value '%s' for 'fps', must be one of '%s'",

Original file line number	Diff line number	Diff line change
`@@ -609,7 +609,7 @@ public function getFps()`
`609`	`609`	`public function setFps($fps)`
`610`	`610`	`{`
`611`	`611`	`$allowedValues = $this->getFpsAllowableValues();`
`612`		`- if (!is_null($fps) && !in_array($fps, $allowedValues, true)) {`
	`612`	`+ if (!is_null($fps) && !in_array($fps, $allowedValues, false)) {`
`613`	`613`	`throw new \InvalidArgumentException(`
`614`	`614`	`sprintf(`
`615`	`615`	`"Invalid value '%s' for 'fps', must be one of '%s'",`