Skip to content

Commit 51c7527

Browse files
authored
Merge pull request #121 from shivammathur/develop
Fix add_extension on linux and macOS
2 parents b3a84fc + 2bf7ab0 commit 51c7527

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/scripts/darwin.sh

+4-4
Original file line numberDiff line numberDiff line change
@@ -37,19 +37,19 @@ add_extension() {
3737
extension=$1
3838
install_command=$2
3939
prefix=$3
40-
if ! php -m | grep -i -q "$extension" && [ -e "$ext_dir/$extension.so" ]; then
40+
if ! php -m | grep -i -q ^"$extension"$ && [ -e "$ext_dir/$extension.so" ]; then
4141
echo "$prefix=$extension" >>"$ini_file" && add_log $tick "$extension" "Enabled"
42-
elif php -m | grep -i -q "$extension"; then
42+
elif php -m | grep -i -q ^"$extension"$; then
4343
add_log "$tick" "$extension" "Enabled"
44-
elif ! php -m | grep -i -q "$extension"; then
44+
elif ! php -m | grep -i -q ^"$extension"$; then
4545
exists=$(curl -sL https://pecl.php.net/json.php?package="$extension" -w "%{http_code}" -o /dev/null)
4646
if [ "$exists" = "200" ]; then
4747
(
4848
eval "$install_command" && \
4949
add_log "$tick" "$extension" "Installed and enabled"
5050
) || add_log "$cross" "$extension" "Could not install $extension on PHP $semver"
5151
else
52-
if ! php -m | grep -i -q "$extension"; then
52+
if ! php -m | grep -i -q ^"$extension"$; then
5353
add_log "$cross" "$extension" "Could not find $extension for PHP $semver on PECL"
5454
fi
5555
fi

src/scripts/linux.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ add_extension()
9696
extension=$1
9797
install_command=$2
9898
prefix=$3
99-
if ! php -m | grep -i -q "$extension" && [ -e "$ext_dir/$extension.so" ]; then
99+
if ! php -m | grep -i -q ^"$extension"$ && [ -e "$ext_dir/$extension.so" ]; then
100100
echo "$prefix=$extension" >> "$ini_file" && add_log "$tick" "$extension" "Enabled"
101-
elif php -m | grep -i -q "$extension"; then
101+
elif php -m | grep -i -q ^"$extension"$; then
102102
add_log "$tick" "$extension" "Enabled"
103-
elif ! php -m | grep -i -q "$extension"; then
103+
elif ! php -m | grep -i -q ^"$extension"$; then
104104
(
105105
eval "$install_command" && \
106106
add_log "$tick" "$extension" "Installed and enabled"

0 commit comments

Comments
 (0)