Silent PHP error uploading a specific image

[carrythebanner]

Create a new event, then try to upload the image below. You'll get the standard Your event has been updated! success message, and the manage_event request returns 200, but it's actually failing with a PHP error and the image is not saved to the event.

Fatal  error: Uncaught exception 'fValidationException' with message 
'The file  uploaded is not an image' in /opt/backend/vendor/flourish/fUpload.php  on line 339
--

1 | {main}(  )               | .../manage_event.php:0
2 | build_json_response(  )  | .../manage_event.php:314
3 | upload_attached_file(  ) | .../manage_event.php:266
4 | fUpload->move(  )        | .../manage_event.php:87

[ionous]

it looks like when the validation fail, the php tries to move (non existent) image anyway, the move throws.

        $file_message = $uploader->validate('file', TRUE);
        if ($file_message != null) {
            $messages = array('file' => $file_message);
        } // <--- should be an "else" here:
        global $IMAGEDIR;
        $file = $uploader->move($IMAGEDIR, 'file');  // < --- throws the exception
        $event->setImage($file->getName());

it seems ob_start captures exceptions... the exception text probably gets written into the response as plain text, but is ignored because the response was 200 ( and wouldnt be in the calendar's special error json format )

as for why the validation failed for the image, i'm not sure. maybe some jpg variant this version of php isn't familiar with?

[carrythebanner]

#485 makes it so the error is no longer silent.

Not sure why this specific image failed — no obvious issues with it. I ran file on it in Terminal and nothing looked fishy. It worked fine for me when converted to PNG, or even just re-exported as a new JPG (using macOS Preview). Might be an odd JPG variant, or have some weird metadata, or something along those lines. The original reporter wasn't sure of the image provenance (grabbed it from the web somewhere) so I'm good to close this now that the error reports more visibly.

[ionous]

( probably related to this flourish issue:
flourishlib/flourish-classes#198
)