fix lint and test

Author: Pearl1594

pkg/cloud/cloud.go

@@ -24,7 +24,7 @@ type Interface interface {
 	DetachVolume(ctx context.Context, volumeID string) error
 	ExpandVolume(ctx context.Context, volumeID string, newSizeInGB int64) error
 
-	CreateVolumeFromSnapshot(ctx context.Context, zoneID, name, domainID, projectID, snapshotID string, sizeInGB int64) (*Volume, error)
+	CreateVolumeFromSnapshot(ctx context.Context, zoneID, name, projectID, snapshotID string, sizeInGB int64) (*Volume, error)
 	GetSnapshotByID(ctx context.Context, snapshotID string) (*Snapshot, error)
 	GetSnapshotByName(ctx context.Context, name string) (*Snapshot, error)
 	CreateSnapshot(ctx context.Context, volumeID string) (*Snapshot, error)

pkg/cloud/fake/fake.go

@@ -13,7 +13,6 @@ import (
 )
 
 const zoneID = "a1887604-237c-4212-a9cd-94620b7880fa"
-const snapshotID = "9d076136-657b-4c84-b279-455da3ea484c"
 
 type fakeConnector struct {
 	node            *cloud.VM
@@ -150,7 +149,7 @@ func (f *fakeConnector) ExpandVolume(_ context.Context, volumeID string, newSize
 	return cloud.ErrNotFound
 }
 
-func (f *fakeConnector) CreateVolumeFromSnapshot(ctx context.Context, zoneID, name, domainID, projectID, snapshotID string, sizeInGB int64) (*cloud.Volume, error) {
+func (f *fakeConnector) CreateVolumeFromSnapshot(ctx context.Context, zoneID, name, projectID, snapshotID string, sizeInGB int64) (*cloud.Volume, error) {
 	vol := &cloud.Volume{
 		ID:             "fake-vol-from-snap-" + name,
 		Name:           name,
@@ -163,15 +162,15 @@ func (f *fakeConnector) CreateVolumeFromSnapshot(ctx context.Context, zoneID, na
 	return vol, nil
 }
 
-func (f *fakeConnector) GetSnapshotByID(ctx context.Context, snapshotID string) (*cloud.Snapshot, error) {
+func (f *fakeConnector) GetSnapshotByID(_ context.Context, snapshotID string) (*cloud.Snapshot, error) {
 	return f.snapshot, nil
 }
 
-func (f *fakeConnector) CreateSnapshot(ctx context.Context, volumeID string) (*cloud.Snapshot, error) {
+func (f *fakeConnector) CreateSnapshot(_ context.Context, volumeID string) (*cloud.Snapshot, error) {
 	return f.snapshot, nil
 }
 
-func (f *fakeConnector) DeleteSnapshot(ctx context.Context, snapshotID string) error {
+func (f *fakeConnector) DeleteSnapshot(_ context.Context, snapshotID string) error {
 	return nil
 }
 

pkg/cloud/snapshots.go

@@ -71,7 +71,7 @@ func (c *client) CreateSnapshot(ctx context.Context, volumeID string) (*Snapshot
 	return &snap, nil
 }
 
-func (c *client) DeleteSnapshot(ctx context.Context, snapshotID string) error {
+func (c *client) DeleteSnapshot(_ context.Context, snapshotID string) error {
 	p := c.Snapshot.NewDeleteSnapshotParams(snapshotID)
 	_, err := c.Snapshot.DeleteSnapshot(p)
 	if err != nil && strings.Contains(err.Error(), "4350") {

pkg/cloud/volumes.go

@@ -164,7 +164,7 @@ func (c *client) ExpandVolume(ctx context.Context, volumeID string, newSizeInGB
 	return nil
 }
 
-func (c *client) CreateVolumeFromSnapshot(ctx context.Context, zoneID, name, domainID, projectID, snapshotID string, sizeInGB int64) (*Volume, error) {
+func (c *client) CreateVolumeFromSnapshot(ctx context.Context, zoneID, name, projectID, snapshotID string, sizeInGB int64) (*Volume, error) {
 	logger := klog.FromContext(ctx)
 
 	p := c.Volume.NewCreateVolumeParams()

pkg/driver/controller.go

@@ -148,7 +148,7 @@ func (cs *controllerServer) CreateVolume(ctx context.Context, req *csi.CreateVol
 			sizeInGB = snapshotSizeGiB
 		}
 
-		volFromSnapshot, err := cs.connector.CreateVolumeFromSnapshot(ctx, snapshot.ZoneID, name, snapshot.DomainID, snapshot.ProjectID, snapshotID, sizeInGB)
+		volFromSnapshot, err := cs.connector.CreateVolumeFromSnapshot(ctx, snapshot.ZoneID, name, snapshot.ProjectID, snapshotID, sizeInGB)
 		if err != nil {
 			return nil, status.Errorf(codes.Internal, "Cannot create volume from snapshot %s: %v", snapshotID, err.Error())
 		}

pkg/mount/mount.go

@@ -231,17 +231,6 @@ func (m *mounter) isDeviceMounted(devicePath string) (bool, error) {
 	return len(output) > 0, nil
 }
 
-func (m *mounter) isDeviceInUse(devicePath string) (bool, error) {
-	output, err := m.Exec.Command("lsof", devicePath).Output()
-	if err != nil {
-		if strings.Contains(err.Error(), "exit status 1") {
-			return false, nil
-		}
-		return false, err
-	}
-	return len(output) > 0, nil
-}
-
 func (m *mounter) getDeviceProperties(devicePath string) (map[string]string, error) {
 	output, err := m.Exec.Command("udevadm", "info", "--query=property", devicePath).Output()
 	if err != nil {