Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow webpack-cli 6.x (non-breaking, requires #536) #533

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow webpack-cli 6.x (non-breaking, requires #536) #533

wants to merge 2 commits into from

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Dec 22, 2024 •
edited
Loading

Blocked by:

Close #532

Summary

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

Other Information

Please test

Summary by CodeRabbit

  • New Features

    • Added support for webpack-cli v6 and webpack-merge v6.
    • Introduced a new configuration option: ensure_consistent_versioning.

  • Breaking Changes

    • Removed CDN URL from manifest.json paths.
    • Deprecated relative_url_root and removed globalMutableWebpackConfig.
    • Default package manager changed to npm, with Yarn support available through configuration.

  • Bug Fixes

    • Addressed errors related to the Rails environment.

  • Documentation

    • Improved documentation for the esbuild loader and Yarn PnP usage.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2024 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces updates to the Shakapacker library, focusing on expanding compatibility with newer versions of webpack-related tools. The changes primarily involve updating the webpack-cli version constraint to support version 6.x, modifying the CHANGELOG.md to document various improvements and breaking changes, and removing some deprecated methods and configuration options. The updates aim to streamline the library's functionality and improve its compatibility with modern development practices.

Changes

File Change Summary
CHANGELOG.md Documented version 8.0.0 breaking changes, including removal of CDN URL paths, deprecation of relative_url_root, and dropping support for Ruby 2.6 and Node v12
package.json Updated webpack-cli version constraint to `^4.9.2
lib/shakapacker.rb Removed verify_file_existance method
lib/tasks/yarn.rake Removed yarn_install and check_yarn methods
config/shakapacker.yml Added new configuration option ensure_consistent_versioning

Assessment against linked issues

Objective Addressed Explanation
Support webpack-cli 6.x [#532] ✅

Poem

🐰 Webpack's new version, six and bright,
Shakapacker leaps with coding might!
Dependencies updated with care,
Breaking changes beyond compare,
A rabbit's dance of code delight! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tagliala
Copy link
Contributor Author 

ERROR:  Error installing bundler:
	bundler-2.6.1 requires Ruby version >= 3.1.0. The current ruby version is 3.0.7.220.

@tagliala tagliala mentioned this pull request Dec 27, 2024
Open
@tagliala
Fix generator specs
17a976f 
Allow bundler installation on Ruby 3.0

Additionally:
- Test against Node 22
- Test against Rails 8.0
- Use latest Ruby 3.1 for dummy specs
- Use proper rspec-rails versions

Close shakacode#534
@tagliala
Allow webpack-cli 6.x
6a99b73 
Close shakacode#532
@tagliala tagliala force-pushed the feature/532-webpack-cli-6 branch from 69122a9 to 6a99b73 Compare December 27, 2024 11:37
@tagliala tagliala marked this pull request as draft December 27, 2024 11:37
@tagliala tagliala changed the title Allow webpack-cli 6.x Allow webpack-cli 6.x (non-breaking) Dec 27, 2024
@tagliala tagliala changed the title Allow webpack-cli 6.x (non-breaking) Allow webpack-cli 6.x (non-breaking, requires #536) Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webpack-cli 6.x support [PR attached]
1 participant
@tagliala