Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trackLabelFormat affects text tracks even when textTrackLabelFormat is set #8016

Closed
xavierlaffargue opened this issue Feb 4, 2025 · 1 comment
Labels
type: bug Something isn't working correctly
Milestone

Comments

@xavierlaffargue
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?

4.13.1

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
Chrome/W11

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

What did you do?

I added
config['trackLabelFormat'] = shaka.ui.Overlay.TrackLabelFormat.LABEL;

Text track on the UI display :
Image

I've in the console :
log.js:148 Track #1000000000 does not have a label, but the UI is configured to only show labels.

What did you expect to happen?
I only configure trackLabelFormat so TextTrackLabelFormat should stay with the default value (LANGUAGE)

What actually happened?

It seems that the label applies to both audio and closed-caption tracks.

And even if I add this I still have the same warning/issue:
config['textTrackLabelFormat'] = shaka.ui.Overlay.TrackLabelFormat.LANGUAGE;

Are you planning to send a PR to fix it?
No

@xavierlaffargue xavierlaffargue added the type: bug Something isn't working correctly label Feb 4, 2025
@shaka-bot shaka-bot added this to the v4.14 milestone Feb 4, 2025
@xavierlaffargue
Copy link
Author

my fault I had a version conflict!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants