Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite #3

Closed
jeromekelleher opened this issue Jun 26, 2024 · 2 comments
Closed

Test suite #3

jeromekelleher opened this issue Jun 26, 2024 · 2 comments

Comments

@jeromekelleher
Copy link
Contributor

It would be good to copy across some of the tests for the VCF writing code from sgkit. Hopefully we can do some easy round-trip tests using bio2zarr?

@tomwhite, what would be involved here?
@tomwhite
Copy link
Contributor

tomwhite commented Jul 1, 2024

I think we can copy them over - I can do that.

It's possible that we will run into sgkit-dev/vcf-zarr-spec#11, but perhaps we change assert_vcfs_close to be more lenient in cases like that.

@jeromekelleher
Copy link
Contributor Author

That sounds like a great plan, thanks @tomwhite!

This was referenced Jul 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomwhite @jeromekelleher