Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert_vcfs_close doesn't handle missingness subtlety #14

Open
jeromekelleher opened this issue Jul 5, 2024 · 1 comment
Open

assert_vcfs_close doesn't handle missingness subtlety #14

jeromekelleher opened this issue Jul 5, 2024 · 1 comment

Comments

@jeromekelleher
Copy link
Contributor

As predicted @tomwhite we've hit sgkit-dev/vcf-zarr-spec#11 pretty quickly when adding tests on real VCF files. I added a quick cludge to workaround the first case I hit, but it would be good to handle this more systematically. Unfortunately, I think it will just need a some ugly code like we have in the validation code in vcf2zarr here
@jeromekelleher
Copy link
Contributor Author

Quick workaround added in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeromekelleher