Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify type of vcf_zarr_version attr #16

Closed
jeromekelleher opened this issue Feb 26, 2024 · 2 comments
Closed

Clarify type of vcf_zarr_version attr #16

jeromekelleher opened this issue Feb 26, 2024 · 2 comments
Milestone
0.3

Comments

@jeromekelleher
Copy link
Contributor

I'm assuming it's a string, but it could be interpreted as a float
@tomwhite
Copy link
Collaborator

Yes, it's a string. In general versions are not floats (e.g. 0.2.1).

@jeromekelleher
Copy link
Contributor Author

I think we just need to put some quotes around the value to make that more obvious.

@tomwhite tomwhite mentioned this issue Mar 3, 2025
Merged
@tomwhite tomwhite added this to the 0.3 milestone Mar 4, 2025
@tomwhite tomwhite closed this as completed Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
2 participants
@tomwhite @jeromekelleher