Skip to content

주식 서버 IndexOutOfBoundsException 해결 및 커스텀 예외 코드 추가 #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ki-met-hoon merged 11 commits into from
Feb 10, 2025
Merged

주식 서버 IndexOutOfBoundsException 해결 및 커스텀 예외 코드 추가 #168

ki-met-hoon merged 11 commits into from
Feb 10, 2025

Conversation

@ki-met-hoon
Copy link
Collaborator

@ki-met-hoon ki-met-hoon commented Feb 10, 2025 •
edited
Loading

Pull request

Related issue

Resolve #167

Motivation and context

  • Open API로부터 빈 배열을 받거나 배열의 길이가 1일 경우 예외 처리
  • 커스텀 예외 코드 추가
    • S50001 == 빈 배열 or 배열의 길이가 1
    • S40002 == client로 부터 요청 받은 objectId가 틀린 경우
    • S40001 == DB로부터 조회된 데이터가 없는 경우

Solution

How has this been tested

image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ki-met-hoon ki-met-hoon added 🐛 BugFix 버그 수정 🎮 BE 백엔드 상 무조건 스프린트내에 해야하는 것들 labels Feb 10, 2025
@ki-met-hoon ki-met-hoon self-assigned this Feb 10, 2025
@netlify
Copy link

netlify bot commented Feb 10, 2025 •
edited
Loading

✅ Deploy Preview for jootalkpia canceled.

Name Link
🔨 Latest commit 22a12b2
🔍 Latest deploy log https://app.netlify.com/sites/jootalkpia/deploys/67a9694e0045b10008627046

@bo-ram-bo-ram
Copy link
Member

bo-ram-bo-ram commented Feb 10, 2025

errorCode -> code로 수정 부탁드려요

@ki-met-hoon ki-met-hoon merged commit 060f409 into dev Feb 10, 2025
5 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bo-ram-bo-ram bo-ram-bo-ram bo-ram-bo-ram approved these changes

Assignees

@ki-met-hoon ki-met-hoon

Labels

상 무조건 스프린트내에 해야하는 것들 🎮 BE 백엔드 🐛 BugFix 버그 수정

Projects

None yet

Milestone

주톡피아 마일스톤2

Development

Successfully merging this pull request may close these issues.

주식 서버 IndexOutOfBoundsException Validation 로직 추가 및 커스텀 예외 코드 추가

3 participants

@ki-met-hoon @bo-ram-bo-ram