Skip to content

Commit 7aff697

Browse files
authored
Merge pull request #1657 from session-foundation/feat/pro-settings
Merge qa of pro-settings to pro-libsession
2 parents c79b156 + bb327b7 commit 7aff697

File tree

5 files changed

+37
-32
lines changed

5 files changed

+37
-32
lines changed

ts/components/dialog/debug/FeatureFlags.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -609,13 +609,13 @@ export const ProDebugSection = ({ forceUpdate }: { forceUpdate: () => void }) =>
609609
label="Expiry"
610610
flag="mockProAccessExpiry"
611611
options={[
612-
{ label: 'Soon', value: MockProAccessExpiryOptions.SOON },
613-
{ label: 'Today', value: MockProAccessExpiryOptions.TODAY },
614-
{ label: 'Tomorrow', value: MockProAccessExpiryOptions.TOMORROW },
615-
{ label: '1 Week', value: MockProAccessExpiryOptions.WEEK },
616-
{ label: '1 Month', value: MockProAccessExpiryOptions.MONTH },
617-
{ label: '3 Months', value: MockProAccessExpiryOptions.THREE_MONTH },
618-
{ label: '1 Year', value: MockProAccessExpiryOptions.YEAR },
612+
{ label: '7 Days', value: MockProAccessExpiryOptions.P7D },
613+
{ label: '29 Days', value: MockProAccessExpiryOptions.P29D },
614+
{ label: '30 Days', value: MockProAccessExpiryOptions.P30D },
615+
{ label: '30 Days 1 Second', value: MockProAccessExpiryOptions.P30DT1S },
616+
{ label: '90 Days', value: MockProAccessExpiryOptions.P90D },
617+
{ label: '300 Days', value: MockProAccessExpiryOptions.P300D },
618+
{ label: '365 Days', value: MockProAccessExpiryOptions.P365D },
619619
{ label: '24 Days 1 Minute', value: MockProAccessExpiryOptions.P24DT1M },
620620
{ label: '24 Hours 1 Minute', value: MockProAccessExpiryOptions.PT24H1M },
621621
{ label: '23 Hours 59 Minutes', value: MockProAccessExpiryOptions.PT23H59M },

ts/components/dialog/user-settings/pages/user-pro/ProNonOriginatingPage.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,7 @@ function ProInfoBlockUpdate() {
285285
}
286286

287287
function ProInfoBlockRenew() {
288+
const dispatch = useDispatch();
288289
const { data } = useProAccessDetails();
289290
return (
290291
<ProInfoBlockLayout
@@ -297,6 +298,9 @@ function ProInfoBlockRenew() {
297298
icon={LUCIDE_ICONS_UNICODE.EXTERNAL_LINK_ICON}
298299
/>
299300
}
301+
descriptionOnClick={() =>
302+
showLinkVisitWarningDialog('https://getsession.org/pro-roadmap', dispatch)
303+
}
300304
subtitleElement={
301305
<ProInfoBlockSectionSubtitle>
302306
{tr('proOptionsTwoRenewalSubtitle')}
@@ -324,7 +328,7 @@ function ProInfoBlockCancel() {
324328
const { data } = useProAccessDetails();
325329
return (
326330
<ProInfoBlockLayout
327-
titleElement={tr('cancelAccess')}
331+
titleElement={tr('proCancellation')}
328332
descriptionElement={
329333
<Localizer
330334
token="proCancellationDescription"

ts/components/dialog/user-settings/pages/user-pro/ProSettingsPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -918,7 +918,7 @@ function PageHero() {
918918
dispatch(
919919
updateLocalizedPopupDialog({
920920
title: { token: 'proStatusError' },
921-
description: { token: 'proStatusNetworkErrorDescription' },
921+
description: { token: 'proStatusRefreshNetworkError' },
922922
overrideButtons: backendErrorButtons,
923923
})
924924
);

ts/hooks/useHasPro.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -83,25 +83,25 @@ export enum ProOriginatingPlatform {
8383
}
8484

8585
function useMockProAccessExpiry() {
86-
const variant = useDataFeatureFlag('mockProAccessExpiry') ?? MockProAccessExpiryOptions.MONTH;
86+
const variant = useDataFeatureFlag('mockProAccessExpiry') ?? MockProAccessExpiryOptions.P30D;
8787

88-
// NOTE: for testing the expiry time should be pinned to x time after "now"
89-
const now = variant ? Date.now() : 0;
88+
// NOTE: for testing the expiry time should be pinned to x + 250ms after "now", the +250ms prevents render lag from changing the timestamp
89+
const now = variant ? Date.now() + 250 : 0;
9090
switch (variant) {
91-
case MockProAccessExpiryOptions.SOON:
92-
return now + 600 * 1000;
93-
case MockProAccessExpiryOptions.TODAY:
94-
return now + 12 * 60 * 60 * 1000;
95-
case MockProAccessExpiryOptions.TOMORROW:
96-
return now + 26 * 60 * 60 * 1000;
97-
case MockProAccessExpiryOptions.WEEK:
98-
return now + 8 * 24 * 60 * 60 * 1000;
99-
case MockProAccessExpiryOptions.MONTH:
91+
case MockProAccessExpiryOptions.P7D:
92+
return now + 7 * 24 * 60 * 60 * 1000;
93+
case MockProAccessExpiryOptions.P29D:
94+
return now + 29 * 24 * 60 * 60 * 1000;
95+
case MockProAccessExpiryOptions.P30D:
10096
return now + 30 * 24 * 60 * 60 * 1000;
101-
case MockProAccessExpiryOptions.THREE_MONTH:
97+
case MockProAccessExpiryOptions.P30DT1S:
98+
return now + 30 * 24 * 60 * 61 * 1000;
99+
case MockProAccessExpiryOptions.P90D:
102100
return now + 90 * 24 * 60 * 60 * 1000;
103-
case MockProAccessExpiryOptions.YEAR:
104-
return now + 12 * 30 * 24 * 60 * 60 * 1000;
101+
case MockProAccessExpiryOptions.P300D:
102+
return now + 300 * 24 * 60 * 60 * 1000;
103+
case MockProAccessExpiryOptions.P365D:
104+
return now + 365 * 24 * 60 * 60 * 1000;
105105
case MockProAccessExpiryOptions.P24DT1M:
106106
return now + 24 * 24 * 60 * 60 * 1000 + 60 * 60 * 1000;
107107
case MockProAccessExpiryOptions.PT24H1M:

ts/state/ducks/types/releasedFeaturesReduxTypes.ts

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,16 @@ export type SessionFeatureFlags = {
2929
fsTTL30s: boolean;
3030
};
3131

32+
// ISO8601 duration format
3233
export enum MockProAccessExpiryOptions {
33-
SOON = 0,
34-
TODAY = 1,
35-
TOMORROW = 2,
36-
WEEK = 3,
37-
MONTH = 4,
38-
THREE_MONTH = 5,
39-
YEAR = 6,
40-
// The following are test cases from the PRD in ISO8601 duration format
34+
P7D = 0,
35+
P29D = 1,
36+
P30D = 2,
37+
P30DT1S = 3,
38+
P90D = 4,
39+
P300D = 5,
40+
P365D = 6,
41+
// The following are test cases from the PRD
4142
P24DT1M = 7,
4243
PT24H1M = 8,
4344
PT23H59M = 9,

0 commit comments

Comments
 (0)