debugmozjs build is not supported on Windows

[saschanaz]

The error says Rustc doesn't support MSVC debug runtime.

AFAIK gecko now supports Windows clang build, can we use it to workaround this?

[jdm]

Unfortunately this is a rustc limitation: rust-lang/rust#39016

[jdm]

Tried to fix this with #190 and CI looked like it worked, but that was a lie:

c:/PROGRA~1/LLVM/bin/clang-cl.exe -FoCompression.obj -c  -DDEBUG=1 -DIMPL_MFBT -DLZ4LIB_VISIBILITY= -Ic:/projects/mozjs/mozjs/mfbt -Ic:/projects/mozjs/target/debug/build/mozjs_sys-574d4207fccb2ff7/out/mfbt -Ic:/projects/mozjs/mozjs/mfbt/double-conversion -Ic:/projects/mozjs/target/debug/build/mozjs_sys-574d4207fccb2ff7/out/dist/include -MDd -FI c:/projects/mozjs/target/debug/build/mozjs_sys-574d4207fccb2ff7/out/js/src/js-confdefs.h -DMOZILLA_CLIENT -Qunused-arguments -guard:cf -Qunused-arguments -MD -TP -nologo -D_CRT_SECURE_NO_WARNINGS -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -guard:cf -W3 -Gy -Zc:inline -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -GR- -Z7 -Oy-  -Xclang -MP -Xclang -dependency-file -Xclang .deps/Compression.obj.pp -Xclang -MT -Xclang Compression.obj   c:/projects/mozjs/mozjs/mfbt/Compression.cpp

The build still contains -MDd and -MD simultaneously.

[jdm]

I'm trying a new fix that looks promising:

• https://github.com/servo/mozjs/compare/fix-debug-mozjs-harder?expand=1
• https://github.com/servo/rust-mozjs/compare/jdm-patch-8?expand=1

[asajeffrey]

Oh that's annoying.