Ricardos comments

Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>

Author: fjtirado

api/src/test/java/io/serverlessworkflow/api/FeaturesTest.java

@@ -45,7 +45,7 @@ public class FeaturesTest {
         "features/try.yaml",
         "features/listen.yaml",
         "features/callFunction.yaml",
-        "features/callCustomFunction.json"
+        "features/callCustomFunction.yaml"
       })
   public void testSpecFeaturesParsing(String workflowLocation) throws IOException {
     Workflow workflow = readWorkflowFromClasspath(workflowLocation);

api/src/test/resources/features/callCustomFunction.json

@@ -0,0 +1,27 @@
+document:
+  dsl: 1.0.0-alpha5
+  namespace: test
+  name: call-example
+  version: 0.1.0
+schedule:
+  cron: 0 8 * * *
+do:
+- getData:
+    call: http
+    with:
+      method: get
+      endpoint: https://api.agify.io?name=meelad
+  output:
+    as: ".data.reading"
+- filterData:
+    for:
+      in: ".data.reading"
+      each: reading
+    do:
+    - log:
+        call: https://raw.githubusercontent.com/serverlessworkflow/catalog/main/functions/log/1.0.0/function.yaml
+        with:
+          level: information
+          format: "{TIMESTAMP} [{LEVEL}] ({CONTEXT}): {MESSAGE}"
+          message: Hello, world!
+          timestamp: true

api/src/test/resources/features/callCustomFunction.yaml

@@ -25,26 +25,26 @@
       <artifactId>jersey-media-json-jackson</artifactId>
       <version>${version.org.glassfish.jersey}</version>
     </dependency>
-       <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter-api</artifactId>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter-engine</artifactId>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter-params</artifactId>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.assertj</groupId>
-            <artifactId>assertj-core</artifactId>
-            <scope>test</scope>
-        </dependency>
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-api</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-engine</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-params</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.assertj</groupId>
+      <artifactId>assertj-core</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
   <build>
     <plugins>

impl/pom.xml

@@ -40,8 +40,8 @@ public HttpExecutor(CallHTTP task) {
 
   @Override
   protected JsonNode internalExecute(JsonNode node) {
-
     HTTPArguments httpArgs = task.getWith();
+    // missing checks
     String uri =
         httpArgs
             .getEndpoint()

impl/src/main/java/io/serverlessworkflow/impl/HttpExecutor.java

@@ -29,21 +29,6 @@
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
-/*
- * Copyright 2020-Present The Serverless Workflow Specification Authors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
 public class WorkflowDefinition {
 
   private WorkflowDefinition(Workflow workflow, Collection<WorkflowExecutionListener> listeners) {