Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix resourceId with a name for the table name #3

Closed
dodgeblaster opened this issue Aug 24, 2019 · 1 comment
Closed

Prefix resourceId with a name for the table name #3

dodgeblaster opened this issue Aug 24, 2019 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dodgeblaster
Copy link
Contributor

dodgeblaster commented Aug 24, 2019

Having the table name generated makes sense to avoid errors and collisions but it might make it hard to find and work with dynamo tables in the aws console. What about prefixing the resourceId name with a string from the inputs:

class AwsDynamoDb extends Component {
  async default(inputs = {}) {
    this.context.status('Deploying')
    const config = mergeDeepRight(defaults, inputs)

    const generatedName = inputs.name + this.context.resourceId()
    config.name = this.state.name || generatedName
@dodgeblaster dodgeblaster changed the title Adding tags to a dynamo table Prefix resourceId with a name for the table name Aug 24, 2019
@eahefnawy
Copy link
Member

Thanks for suggesting that @dodgeblaster ... we get that a lot actually and I think you're right. I think it's best to just offer an optional name input. Should be super easy. PR welcome!

@eahefnawy eahefnawy added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants