diff --git a/bin/download-models.py b/bin/download-models.py index 239c325..a72e2d8 100755 --- a/bin/download-models.py +++ b/bin/download-models.py @@ -52,7 +52,26 @@ def main(url): serenade.packages.download(f"{url}/{path}/{model}.tar.gz", archive) with tarfile.open(archive, mode="r:gz") as f: - f.extractall(os.path.dirname(archive)) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, os.path.dirname(archive)) os.remove(archive)