Merge remote-tracking branch 'origin/master'

Author: seregazhuk

.travis.yml

@@ -5,20 +5,23 @@ jobs:
     - stage: "PHP7.2 - lowest"
       php: 7.2
       script:
-        - composer update -n --prefer-dist  --prefer-lowest --no-suggest
+        - composer update -n --prefer-dist --prefer-lowest --no-suggest
         - composer dump-autoload
-        - php vendor/bin/phpunit
+        - composer ci:tests
+        - composer ci:php:psalm
 
     - stage: "PHP7.3 - highest"
       php: 7.3
       script:
         - composer update -n --prefer-dist --no-suggest
         - composer dump-autoload
-        - php vendor/bin/phpunit
+        - composer ci:tests
+        - composer ci:php:psalm
 
     - stage: "PHP7.4 - highest"
       php: 7.4
       script:
         - composer update -n --prefer-dist --no-suggest
         - composer dump-autoload
-        - php vendor/bin/phpunit
+        - composer ci:tests
+        - composer ci:php:psalm

composer.json

@@ -52,7 +52,13 @@
     "require-dev": {
         "symfony/process": "^4.3",
         "phpunit/phpunit": "^8.0",
-        "clue/block-react": "^1.3"
+        "clue/block-react": "^1.3",
+        "vimeo/psalm": "^3.8"
+    },
+
+    "scripts": {
+      "ci:php:psalm": "vendor/bin/psalm --show-info=false",
+      "ci:tests": "vendor/bin/phpunit tests"
     },
     "minimum-stability": "alpha"
 }

psalm.xml

@@ -0,0 +1,55 @@
+<?xml version="1.0"?>
+<psalm
+    totallyTyped="false"
+    resolveFromConfigFile="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+>
+    <projectFiles>
+        <directory name="src" />
+        <ignoreFiles>
+            <directory name="vendor" />
+        </ignoreFiles>
+    </projectFiles>
+
+    <issueHandlers>
+        <LessSpecificReturnType errorLevel="info" />
+
+        <!-- level 3 issues - slightly lazy code writing, but provably low false-negatives -->
+
+        <DeprecatedMethod errorLevel="info" />
+        <DeprecatedProperty errorLevel="info" />
+        <DeprecatedClass errorLevel="info" />
+        <DeprecatedConstant errorLevel="info" />
+        <DeprecatedFunction errorLevel="info" />
+        <DeprecatedInterface errorLevel="info" />
+        <DeprecatedTrait errorLevel="info" />
+
+        <InternalMethod errorLevel="info" />
+        <InternalProperty errorLevel="info" />
+        <InternalClass errorLevel="info" />
+
+        <MissingClosureReturnType errorLevel="info" />
+        <MissingReturnType errorLevel="info" />
+        <MissingPropertyType errorLevel="suppress" />
+        <InvalidDocblock errorLevel="info" />
+        <MisplacedRequiredParam errorLevel="info" />
+
+        <PropertyNotSetInConstructor errorLevel="info" />
+        <MissingConstructor errorLevel="info" />
+        <MissingClosureParamType errorLevel="info" />
+        <MissingParamType errorLevel="info" />
+
+        <RedundantCondition errorLevel="info" />
+
+        <DocblockTypeContradiction errorLevel="info" />
+        <RedundantConditionGivenDocblockType errorLevel="info" />
+
+        <UnresolvableInclude errorLevel="info" />
+
+        <RawObjectIteration errorLevel="info" />
+
+        <InvalidStringClass errorLevel="info" />
+    </issueHandlers>
+</psalm>

src/Filesystem/ChangesListener.php

@@ -36,7 +36,7 @@ private function handleOutput(Process $process): void
             throw new RuntimeException('Cannot open STDOUT for filesystem watcher');
         }
 
-        $process->stdout->on('data', function ($data) {
+        $process->stdout->on('data', function (string $data) {
             if ((bool)$data) {
                 $this->emit('change');
             }

src/WatcherCommand.php

@@ -61,7 +61,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
      */
     private function addTerminationListeners(LoopInterface $loop, SpinnerInterface $spinner): void
     {
-        $func = static function (int $signal) use ($spinner) {
+        $func = static function (int $signal) use ($spinner): void {
             $spinner->end();
             exit($signal);
         };