Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WQL queries should support setting max elements #35

Open
htayj opened this issue Jul 24, 2024 · 0 comments
Open

WQL queries should support setting max elements #35

htayj opened this issue Jul 24, 2024 · 0 comments

Comments

@htayj
Copy link

htayj commented Jul 24, 2024

When calling WinRMWqlExecutor (WinRMWqlExecutor.java) there is no way to set the maxElements which will eventually be used in the pull (WinRMService.java#L490). Without being able to set this, it defaults to 1 max element, in which case a new request is used for every element. This leads to extremely long WQL poll times.

I suggest adding an optional parameter to pull and allowing users to pass it in when making WQL queries. This will greatly improve poll times for WQL queries that return large responses. The Pull class already supports maxElements so it should just be a matter of feeding the parameter from the top level call and setting it on the pull method similar to setEnumerationContext here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant