don't log listenbrainz scrobble errors

sentriz · sentriz · commit a8e50c4a016e · 2022-03-24T00:11:11.000Z
we're already logging at the subsonic level
diff --git a/server/ctrlsubsonic/handlers_common.go b/server/ctrlsubsonic/handlers_common.go
@@ -65,10 +65,8 @@ func (c *Controller) ServeScrobble(r *http.Request) *spec.Response {
 			scrobbleErrs.Add(err)
 		}
 	}
-
 	if scrobbleErrs.Len() > 0 {
-		log.Printf("error when submitting: %v", scrobbleErrs)
-		return spec.NewError(0, "error when submitting: %v", scrobbleErrs)
+		return spec.NewError(0, "error when submitting: %s", scrobbleErrs.Error())
 	}
 
 	return spec.NewResponse()

Original file line number	Diff line number	Diff line change
`@@ -65,10 +65,8 @@ func (c Controller) ServeScrobble(r http.Request) *spec.Response {`
`65`	`65`	`scrobbleErrs.Add(err)`
`66`	`66`	`}`
`67`	`67`	`}`
`68`		`-`
`69`	`68`	`if scrobbleErrs.Len() > 0 {`
`70`		`- log.Printf("error when submitting: %v", scrobbleErrs)`
`71`		`- return spec.NewError(0, "error when submitting: %v", scrobbleErrs)`
	`69`	`+ return spec.NewError(0, "error when submitting: %s", scrobbleErrs.Error())`
`72`	`70`	`}`
`73`	`71`
`74`	`72`	`return spec.NewResponse()`